fix(node): improve error message requiring non-npm es module (#19856)

Closes #19842
Closes #16913

6 files changed, 19 insertions, 6 deletions

diff --git a/cli/tests/integration/npm_tests.rs b/cli/tests/integration/npm_tests.rs
index 3ecc271e4..2f998e3a2 100644
--- a/cli/tests/integration/npm_tests.rs
+++ b/cli/tests/integration/npm_tests.rs
@@ -104,6 +104,14 @@ itest!(cjs_require_esm_mjs_error {
   exit_code: 1,
 });
 
+itest!(require_esm_error {
+  args: "run --allow-read --quiet node/require_esm_error/main.ts",
+  output: "node/require_esm_error/main.out",
+  envs: env_vars_for_npm_tests(),
+  http_server: true,
+  exit_code: 1,
+});
+
 itest!(translate_cjs_to_esm {
   args: "run -A --quiet npm/translate_cjs_to_esm/main.js",
   output: "npm/translate_cjs_to_esm/main.out",
diff --git a/cli/tests/testdata/node/require_esm_error/esm.js b/cli/tests/testdata/node/require_esm_error/esm.js
new file mode 100644
index 000000000..0613f1911
--- /dev/null
+++ b/cli/tests/testdata/node/require_esm_error/esm.js
@@ -0,0 +1 @@
+export class Test {}
diff --git a/cli/tests/testdata/node/require_esm_error/main.out b/cli/tests/testdata/node/require_esm_error/main.out
new file mode 100644
index 000000000..c7b355411
--- /dev/null
+++ b/cli/tests/testdata/node/require_esm_error/main.out
@@ -0,0 +1,3 @@
+error: Uncaught Error: require() of ES Module [WILDCARD]esm.js from [WILDCARD]main.ts not supported. Instead change the require to a dynamic import() which is available in all CommonJS modules.
+    at [WILDCARD]
+    at file:///[WILDCARD]/require_esm_error/main.ts:5:1
diff --git a/cli/tests/testdata/node/require_esm_error/main.ts b/cli/tests/testdata/node/require_esm_error/main.ts
new file mode 100644
index 000000000..612e91714
--- /dev/null
+++ b/cli/tests/testdata/node/require_esm_error/main.ts
@@ -0,0 +1,5 @@
+import { createRequire } from "node:module";
+
+const require = createRequire(import.meta.url);
+
+require("./esm.js");
diff --git a/cli/tests/testdata/npm/cjs_require_esm_error/main.out b/cli/tests/testdata/npm/cjs_require_esm_error/main.out
index dcb3d15b7..5c735b3a6 100644
--- a/cli/tests/testdata/npm/cjs_require_esm_error/main.out
+++ b/cli/tests/testdata/npm/cjs_require_esm_error/main.out
@@ -1,4 +1,2 @@
-error: Uncaught Error: [ERR_REQUIRE_ESM]: require() of ES Module [WILDCARD]my_esm_module.js from [WILDCARD]index.js not supported. Instead change the require to a dynamic import() which is available in all CommonJS modules.
-    at Object.Module._extensions..js (node:module:[WILDCARD])
+error: Uncaught Error: require() of ES Module [WILDCARD]my_esm_module.js from [WILDCARD]index.js not supported. Instead change the require to a dynamic import() which is available in all CommonJS modules.
     [WILDCARD]
-    at Module.load (node:module:[WILDCARD])
diff --git a/cli/tests/testdata/npm/cjs_require_esm_mjs_error/main.out b/cli/tests/testdata/npm/cjs_require_esm_mjs_error/main.out
index df37e997a..e6a8abe27 100644
--- a/cli/tests/testdata/npm/cjs_require_esm_mjs_error/main.out
+++ b/cli/tests/testdata/npm/cjs_require_esm_mjs_error/main.out
@@ -1,4 +1,2 @@
-error: Uncaught Error: [ERR_REQUIRE_ESM]: require() of ES Module [WILDCARD]esm_mjs.mjs from [WILDCARD]require_mjs.js not supported. Instead change the require to a dynamic import() which is available in all CommonJS modules.
-    at Module.load (node:module:[WILDCARD])
+error: Uncaught Error: require() of ES Module [WILDCARD]esm_mjs.mjs from [WILDCARD]require_mjs.js not supported. Instead change the require to a dynamic import() which is available in all CommonJS modules.
     [WILDCARD]
-    at Function.Module._load (node:module:[WILDCARD])