diff options
author | Asher Gomez <ashersaupingomez@gmail.com> | 2023-01-04 07:50:14 +1100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-01-03 21:50:14 +0100 |
commit | 1b001d1b180535ce247b5ebd9d38435384ddf787 (patch) | |
tree | 4b486dcccbfc8e28efbe772c5bbdba0d4341aac5 /cli/tests | |
parent | deed07e1d9f103d9829164f03436bd4852ee42e5 (diff) |
fix(permissions): process `URL` in `Deno.FfiPermissionDescriptor.path` for `revoke()` and `request()` (#17094)
Previously, `Deno.permissions.[revoke|request]()` wouldn't correctly
process the `path: URL` when `name` was `ffi`. This change fixes that
behaviour and adds a new function, `formDescriptor()`, to ensure `URL`
arguments are consistently handled across
`Deno.permissions.[query|revoke|request]()`.
Diffstat (limited to 'cli/tests')
-rw-r--r-- | cli/tests/unit/permissions_test.ts | 19 |
1 files changed, 7 insertions, 12 deletions
diff --git a/cli/tests/unit/permissions_test.ts b/cli/tests/unit/permissions_test.ts index 9f9b605f9..193e60689 100644 --- a/cli/tests/unit/permissions_test.ts +++ b/cli/tests/unit/permissions_test.ts @@ -75,19 +75,14 @@ Deno.test(function permissionStatusIllegalConstructor() { assertEquals(Deno.PermissionStatus.length, 0); }); +// Regression test for https://github.com/denoland/deno/issues/17020 Deno.test(async function permissionURL() { - await Deno.permissions.query({ - name: "read", - path: new URL(".", import.meta.url), - }); - await Deno.permissions.query({ - name: "write", - path: new URL(".", import.meta.url), - }); - await Deno.permissions.query({ - name: "run", - command: new URL(".", import.meta.url), - }); + const path = new URL(".", import.meta.url); + + await Deno.permissions.query({ name: "read", path }); + await Deno.permissions.query({ name: "write", path }); + await Deno.permissions.query({ name: "ffi", path }); + await Deno.permissions.query({ name: "run", command: path }); }); Deno.test(async function permissionDescriptorValidation() { |