diff options
| author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2023-06-15 20:36:33 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-15 18:36:33 +0000 |
| commit | 0733943fe7de30fa54d6cd8ee34f7393e8bb7482 (patch) | |
| tree | a4eab892bdc6c93b0e66590d619e172d2d2dcdbe /cli/tests | |
| parent | fa63fd4610fbe4a1d95c4da776e4a1cfa8f8e0b9 (diff) | |
fix(cli): avoid crash on import of invalid module names (#19523)
Fixes https://github.com/denoland/deno/issues/17748
Closes #17770
Co-authored-by: Anton Bershanskiy
<bershanskiy@users.noreply.github.com>
Co-authored-by: David Sherret <dsherret@users.noreply.github.com>
Diffstat (limited to 'cli/tests')
3 files changed, 19 insertions, 0 deletions
diff --git a/cli/tests/integration/npm_tests.rs b/cli/tests/integration/npm_tests.rs index c38e4f75f..014f22658 100644 --- a/cli/tests/integration/npm_tests.rs +++ b/cli/tests/integration/npm_tests.rs @@ -183,6 +183,13 @@ itest!(dynamic_import_reload_same_package { http_server: true, }); +itest!(dynamic_import_invalid_package_name { + args: "run -A --reload npm/dynamic_import_invalid_package_name/main.ts", + output: "npm/dynamic_import_invalid_package_name/main.out", + envs: env_vars_for_npm_tests(), + http_server: true, +}); + itest!(env_var_re_export_dev { args: "run --allow-read --allow-env --quiet npm/env_var_re_export/main.js", output_str: Some("dev\n"), diff --git a/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.out b/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.out new file mode 100644 index 000000000..0e9de5f25 --- /dev/null +++ b/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.out @@ -0,0 +1,6 @@ +Download http://localhost:4545/npm/registry/ws%3A +FAILED +TypeError: npm package 'ws:' does not exist. + at async file:///[WILDCARD]/dynamic_import_invalid_package_name/main.ts:2:3 { + code: "ERR_MODULE_NOT_FOUND" +} diff --git a/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.ts b/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.ts new file mode 100644 index 000000000..368ccc282 --- /dev/null +++ b/cli/tests/testdata/npm/dynamic_import_invalid_package_name/main.ts @@ -0,0 +1,6 @@ +try { + await import(`npm:${"ws:"}`); +} catch (err) { + console.log("FAILED"); + console.log(err); +} |
