diff options
author | Nayeem Rahman <nayeemrmn99@gmail.com> | 2020-12-30 22:35:28 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-12-30 23:35:28 +0100 |
commit | 22e0ee92a6618db0168b9dfce6c598b6df207a4c (patch) | |
tree | d2d2a4ad13c168948cadaebf8c70f2f2ef0c0888 /cli/tests/unit | |
parent | bcdc2da4c75869480b960d437747feb0feff04c2 (diff) |
BREAKING(unstable): Use hosts for net allowlists (#8845)
Allowlist checking already uses hosts but for some reason
requests, revokes and the runtime permissions API use URLs.
- BREAKING(lib.deno.unstable.d.ts): Change
NetPermissionDescriptor::url to NetPermissionDescriptor::host
- fix(runtime/permissions): Don't add whole URLs to the
allowlist on request
- fix(runtime/permissions): Harden strength semantics:
({ name: "net", host: "127.0.0.1" } is stronger than
{ name: "net", host: "127.0.0.1:8000" }) for blocklisting
- refactor(runtime/permissions): Use tuples for hosts, make
the host optional in Permissions::{query_net, request_net, revoke_net}()
Diffstat (limited to 'cli/tests/unit')
-rw-r--r-- | cli/tests/unit/permissions_test.ts | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cli/tests/unit/permissions_test.ts b/cli/tests/unit/permissions_test.ts index dee8aa195..3c36f0186 100644 --- a/cli/tests/unit/permissions_test.ts +++ b/cli/tests/unit/permissions_test.ts @@ -13,9 +13,9 @@ unitTest(async function permissionInvalidName(): Promise<void> { }, Error); }); -unitTest(async function permissionNetInvalidUrl(): Promise<void> { +unitTest(async function permissionNetInvalidHost(): Promise<void> { await assertThrowsAsync(async () => { - await Deno.permissions.query({ name: "net", url: ":" }); + await Deno.permissions.query({ name: "net", host: ":" }); }, URIError); }); |