diff options
| author | Bartek Iwańczuk <biwanczuk@gmail.com> | 2023-05-19 02:59:23 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-19 02:59:23 +0200 |
| commit | 5b0752234993ee69e47c32db478d2a296f73f396 (patch) | |
| tree | 6501e364a82d6ff98845d87fe38744bda7fd1a70 /cli/tests/unit/serve_test.ts | |
| parent | 8724ba9d084127147e2bb2c997a6bf2f38c9b3d2 (diff) | |
BREAKING(unstable): change return type of Deno.serve() API (#19189)
This commit changes the return type of an unstable `Deno.serve()` API
to instead return a `Deno.Server` object that has a `finished` field.
This change is done in preparation to be able to ref/unref the HTTP
server.
Diffstat (limited to 'cli/tests/unit/serve_test.ts')
| -rw-r--r-- | cli/tests/unit/serve_test.ts | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/cli/tests/unit/serve_test.ts b/cli/tests/unit/serve_test.ts index 5da300dc9..c6cfc45f3 100644 --- a/cli/tests/unit/serve_test.ts +++ b/cli/tests/unit/serve_test.ts @@ -6,7 +6,6 @@ import { TextProtoReader } from "../testdata/run/textproto.ts"; import { assert, assertEquals, - assertRejects, assertStringIncludes, assertThrows, Deferred, @@ -50,7 +49,7 @@ Deno.test(async function httpServerShutsDownPortBeforeResolving() { assertThrows(() => Deno.listen({ port: 4501 })); ac.abort(); - await server; + await server.finished; const listener = Deno.listen({ port: 4501 }); listener!.close(); @@ -93,7 +92,7 @@ Deno.test(async function httpServerRejectsOnAddrInUse() { }); await listeningPromise; - await assertRejects( + assertThrows( () => Deno.serve({ handler: (_req) => new Response("ok"), @@ -284,18 +283,18 @@ Deno.test({ permissions: { net: true } }, async function httpServerOverload2() { Deno.test( { permissions: { net: true } }, - async function httpServerErrorOverloadMissingHandler() { + function httpServerErrorOverloadMissingHandler() { // @ts-ignore - testing invalid overload - await assertRejects(() => Deno.serve(), TypeError, "handler"); + assertThrows(() => Deno.serve(), TypeError, "handler"); // @ts-ignore - testing invalid overload - await assertRejects(() => Deno.serve({}), TypeError, "handler"); - await assertRejects( + assertThrows(() => Deno.serve({}), TypeError, "handler"); + assertThrows( // @ts-ignore - testing invalid overload () => Deno.serve({ handler: undefined }), TypeError, "handler", ); - await assertRejects( + assertThrows( // @ts-ignore - testing invalid overload () => Deno.serve(undefined, { handler: () => {} }), TypeError, |