diff options
| author | Bartek Iwańczuk <biwanczuk@gmail.com> | 2020-10-14 14:04:09 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-14 14:04:09 +0200 |
| commit | 135053486c4bd112ebd7d0b25c94a8dd346472e6 (patch) | |
| tree | 24eae514d8de332a0968de869172f651b30b5078 /cli/tests/top_level_await_circular.out | |
| parent | 10654fa95553866c63a56a7f84c7ec47fb7aac9c (diff) | |
fix: top-level-await module execution (#7946)
This commit changes implementation of top-level-await in "deno_core".
Previously promise returned from module evaluation was not awaited,
leading to out-of-order execution of modules that have TLA. It's been
fixed by changing "JsRuntime::mod_evaluate" to be an async function
that resolves when the promise returned from module evaluation also
resolves. When waiting for promise resolution event loop is polled
repeatedly, until there are no more dynamic imports or pending
ops.
Diffstat (limited to 'cli/tests/top_level_await_circular.out')
| -rw-r--r-- | cli/tests/top_level_await_circular.out | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/cli/tests/top_level_await_circular.out b/cli/tests/top_level_await_circular.out new file mode 100644 index 000000000..d47564441 --- /dev/null +++ b/cli/tests/top_level_await_circular.out @@ -0,0 +1,7 @@ +timeout loop 0 +timeout loop 1 +timeout loop 2 +timeout loop 3 +timeout loop 4 +timeout loop 5 +error: Dynamically imported module evaluation is still pending but there are no pending ops. This situation is often caused by unresolved promise. |