refactor: remove `DENO_UNSTABLE_NPM_SYNC_DOWNLOAD` and custom sync functionality (#20504)

https://github.com/denoland/deno/pull/20488 enables us to remove this
functionality. This is better because our test suite is now not testing
a separate code path.

17 files changed, 62 insertions, 0 deletions

diff --git a/cli/tests/testdata/check/jsx_not_checked/main.out b/cli/tests/testdata/check/jsx_not_checked/main.out
index a4e1c60e4..82c1c2358 100644
--- a/cli/tests/testdata/check/jsx_not_checked/main.out
+++ b/cli/tests/testdata/check/jsx_not_checked/main.out
@@ -1,9 +1,11 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/react
 Download http://localhost:4545/npm/registry/loose-envify
 Download http://localhost:4545/npm/registry/js-tokens
 Download http://localhost:4545/npm/registry/react/react-18.2.0.tgz
 Download http://localhost:4545/npm/registry/loose-envify/loose-envify-1.4.0.tgz
 Download http://localhost:4545/npm/registry/js-tokens/js-tokens-4.0.0.tgz
+[UNORDERED_END]
 Check file:///[WILDCARD]/jsx_not_checked/main.jsx
 error: TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'number'.
 console.log(add("1", "2"));
diff --git a/cli/tests/testdata/npm/cjs_sub_path/main.out b/cli/tests/testdata/npm/cjs_sub_path/main.out
index e6e70f3aa..34ec9d63f 100644
--- a/cli/tests/testdata/npm/cjs_sub_path/main.out
+++ b/cli/tests/testdata/npm/cjs_sub_path/main.out
@@ -1,3 +1,4 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/ajv
 Download http://localhost:4545/npm/registry/ajv-formats
 Download http://localhost:4545/npm/registry/chai
@@ -13,6 +14,8 @@ Download http://localhost:4545/npm/registry/loupe
 Download http://localhost:4545/npm/registry/pathval
 Download http://localhost:4545/npm/registry/type-detect
 Download http://localhost:4545/npm/registry/punycode
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/ajv/ajv-8.11.0.tgz
 Download http://localhost:4545/npm/registry/ajv-formats/ajv-formats-2.1.1.tgz
 Download http://localhost:4545/npm/registry/assertion-error/assertion-error-1.1.0.tgz
@@ -28,4 +31,5 @@ Download http://localhost:4545/npm/registry/punycode/punycode-2.1.1.tgz
 Download http://localhost:4545/npm/registry/require-from-string/require-from-string-2.0.2.tgz
 Download http://localhost:4545/npm/registry/type-detect/type-detect-4.0.8.tgz
 Download http://localhost:4545/npm/registry/uri-js/uri-js-4.4.1.tgz
+[UNORDERED_END]
 Fini
diff --git a/cli/tests/testdata/npm/cjs_with_deps/main.out b/cli/tests/testdata/npm/cjs_with_deps/main.out
index 3a16ff467..aac21abba 100644
--- a/cli/tests/testdata/npm/cjs_with_deps/main.out
+++ b/cli/tests/testdata/npm/cjs_with_deps/main.out
@@ -1,3 +1,4 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/chalk
 Download http://localhost:4545/npm/registry/chai
 Download http://localhost:4545/npm/registry/ansi-styles
@@ -12,6 +13,8 @@ Download http://localhost:4545/npm/registry/type-detect
 Download http://localhost:4545/npm/registry/color-convert
 Download http://localhost:4545/npm/registry/has-flag
 Download http://localhost:4545/npm/registry/color-name
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/ansi-styles/ansi-styles-4.3.0.tgz
 Download http://localhost:4545/npm/registry/assertion-error/assertion-error-1.1.0.tgz
 Download http://localhost:4545/npm/registry/chai/chai-4.3.6.tgz
@@ -26,4 +29,5 @@ Download http://localhost:4545/npm/registry/loupe/loupe-2.3.4.tgz
 Download http://localhost:4545/npm/registry/pathval/pathval-1.1.1.tgz
 Download http://localhost:4545/npm/registry/supports-color/supports-color-7.2.0.tgz
 Download http://localhost:4545/npm/registry/type-detect/type-detect-4.0.8.tgz
+[UNORDERED_END]
 chalk cjs loads
diff --git a/cli/tests/testdata/npm/cjs_with_deps/main_node_modules.out b/cli/tests/testdata/npm/cjs_with_deps/main_node_modules.out
index 1ae22f510..548f567f1 100644
--- a/cli/tests/testdata/npm/cjs_with_deps/main_node_modules.out
+++ b/cli/tests/testdata/npm/cjs_with_deps/main_node_modules.out
@@ -1,3 +1,4 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/chalk
 Download http://localhost:4545/npm/registry/chai
 Download http://localhost:4545/npm/registry/ansi-styles
@@ -12,6 +13,8 @@ Download http://localhost:4545/npm/registry/type-detect
 Download http://localhost:4545/npm/registry/color-convert
 Download http://localhost:4545/npm/registry/has-flag
 Download http://localhost:4545/npm/registry/color-name
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/ansi-styles/ansi-styles-4.3.0.tgz
 Initialize ansi-styles@4.3.0
 Download http://localhost:4545/npm/registry/assertion-error/assertion-error-1.1.0.tgz
@@ -40,4 +43,5 @@ Download http://localhost:4545/npm/registry/supports-color/supports-color-7.2.0.
 Initialize supports-color@7.2.0
 Download http://localhost:4545/npm/registry/type-detect/type-detect-4.0.8.tgz
 Initialize type-detect@4.0.8
+[UNORDERED_END]
 chalk cjs loads
diff --git a/cli/tests/testdata/npm/cjs_yargs/main.out b/cli/tests/testdata/npm/cjs_yargs/main.out
index 6aa34bce8..422cbb134 100644
--- a/cli/tests/testdata/npm/cjs_yargs/main.out
+++ b/cli/tests/testdata/npm/cjs_yargs/main.out
@@ -1,3 +1,4 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/yargs
 Download http://localhost:4545/npm/registry/cliui
 Download http://localhost:4545/npm/registry/decamelize
@@ -24,6 +25,8 @@ Download http://localhost:4545/npm/registry/color-convert
 Download http://localhost:4545/npm/registry/p-limit
 Download http://localhost:4545/npm/registry/color-name
 Download http://localhost:4545/npm/registry/p-try
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/ansi-regex/ansi-regex-5.0.1.tgz
 Initialize ansi-regex@5.0.1
 Download http://localhost:4545/npm/registry/ansi-styles/ansi-styles-4.3.0.tgz
@@ -76,5 +79,6 @@ Download http://localhost:4545/npm/registry/yargs/yargs-15.4.1.tgz
 Initialize yargs@15.4.1
 Download http://localhost:4545/npm/registry/yargs-parser/yargs-parser-18.1.3.tgz
 Initialize yargs-parser@18.1.3
+[UNORDERED_END]
 start server on :8000
 [WILDCARD]
diff --git a/cli/tests/testdata/npm/compare_globals/main.out b/cli/tests/testdata/npm/compare_globals/main.out
index 46900b882..31fcedda3 100644
--- a/cli/tests/testdata/npm/compare_globals/main.out
+++ b/cli/tests/testdata/npm/compare_globals/main.out
@@ -1,7 +1,11 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@types/node
 Download http://localhost:4545/npm/registry/@denotest/globals
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/globals/1.0.0.tgz
 Download http://localhost:4545/npm/registry/@types/node/node-18.8.2.tgz
+[UNORDERED_END]
 Check file:///[WILDCARD]/npm/compare_globals/main.ts
 true
 true
diff --git a/cli/tests/testdata/npm/conditional_exports/main.out b/cli/tests/testdata/npm/conditional_exports/main.out
index 9f65c1f9a..dbd1b87fe 100644
--- a/cli/tests/testdata/npm/conditional_exports/main.out
+++ b/cli/tests/testdata/npm/conditional_exports/main.out
@@ -1,11 +1,15 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/conditional-exports
 Download http://localhost:4545/npm/registry/supports-esm
 Download http://localhost:4545/npm/registry/has-package-exports
 Download http://localhost:4545/npm/registry/@ljharb/has-package-exports-patterns
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/conditional-exports/1.0.0.tgz
 Download http://localhost:4545/npm/registry/@ljharb/has-package-exports-patterns/has-package-exports-patterns-0.0.2.tgz
 Download http://localhost:4545/npm/registry/has-package-exports/has-package-exports-1.3.0.tgz
 Download http://localhost:4545/npm/registry/supports-esm/supports-esm-1.0.0.tgz
+[UNORDERED_END]
 { hello: "from esm" }
 { hello: "from foo" }
 { hello: "from esm client" }
diff --git a/cli/tests/testdata/npm/conditional_exports/main_node_modules.out b/cli/tests/testdata/npm/conditional_exports/main_node_modules.out
index 94ce95581..460aec0f1 100644
--- a/cli/tests/testdata/npm/conditional_exports/main_node_modules.out
+++ b/cli/tests/testdata/npm/conditional_exports/main_node_modules.out
@@ -1,7 +1,10 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/conditional-exports
 Download http://localhost:4545/npm/registry/supports-esm
 Download http://localhost:4545/npm/registry/has-package-exports
 Download http://localhost:4545/npm/registry/@ljharb/has-package-exports-patterns
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/conditional-exports/1.0.0.tgz
 Initialize @denotest/conditional-exports@1.0.0
 Download http://localhost:4545/npm/registry/@ljharb/has-package-exports-patterns/has-package-exports-patterns-0.0.2.tgz
@@ -10,6 +13,7 @@ Download http://localhost:4545/npm/registry/has-package-exports/has-package-expo
 Initialize has-package-exports@1.3.0
 Download http://localhost:4545/npm/registry/supports-esm/supports-esm-1.0.0.tgz
 Initialize supports-esm@1.0.0
+[UNORDERED_END]
 { hello: "from esm" }
 { hello: "from foo" }
 { hello: "from esm client" }
diff --git a/cli/tests/testdata/npm/deno_cache.out b/cli/tests/testdata/npm/deno_cache.out
index e4f03e2f1..e2e68b7bb 100644
--- a/cli/tests/testdata/npm/deno_cache.out
+++ b/cli/tests/testdata/npm/deno_cache.out
@@ -1,4 +1,8 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/chalk
 Download http://localhost:4545/npm/registry/mkdirp
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/chalk/chalk-5.0.1.tgz
 Download http://localhost:4545/npm/registry/mkdirp/mkdirp-1.0.4.tgz
+[UNORDERED_END]
diff --git a/cli/tests/testdata/npm/import_map/main.out b/cli/tests/testdata/npm/import_map/main.out
index 29f0f4283..a3d1d9f3a 100644
--- a/cli/tests/testdata/npm/import_map/main.out
+++ b/cli/tests/testdata/npm/import_map/main.out
@@ -1,6 +1,10 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/chalk
 Download http://localhost:4545/npm/registry/@denotest/dual-cjs-esm
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/dual-cjs-esm/1.0.0.tgz
 Download http://localhost:4545/npm/registry/chalk/chalk-5.0.1.tgz
+[UNORDERED_END]
 chalk import map loads
 esm
diff --git a/cli/tests/testdata/npm/mixed_case_package_name/global.out b/cli/tests/testdata/npm/mixed_case_package_name/global.out
index 72417dd71..33d09890b 100644
--- a/cli/tests/testdata/npm/mixed_case_package_name/global.out
+++ b/cli/tests/testdata/npm/mixed_case_package_name/global.out
@@ -1,5 +1,9 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/MixedCase
 Download http://localhost:4545/npm/registry/@denotest/CAPITALS
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/CAPITALS/1.0.0.tgz
 Download http://localhost:4545/npm/registry/@denotest/MixedCase/1.0.0.tgz
+[UNORDERED_END]
 5
diff --git a/cli/tests/testdata/npm/mixed_case_package_name/local.out b/cli/tests/testdata/npm/mixed_case_package_name/local.out
index d21377fd6..782107eb1 100644
--- a/cli/tests/testdata/npm/mixed_case_package_name/local.out
+++ b/cli/tests/testdata/npm/mixed_case_package_name/local.out
@@ -1,9 +1,13 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/MixedCase
 Download http://localhost:4545/npm/registry/@denotest/CAPITALS
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/CAPITALS/1.0.0.tgz
 Initialize @denotest/CAPITALS@1.0.0
 Download http://localhost:4545/npm/registry/@denotest/MixedCase/1.0.0.tgz
 Initialize @denotest/MixedCase@1.0.0
+[UNORDERED_END]
 5
 true
 true
diff --git a/cli/tests/testdata/npm/peer_deps_with_copied_folders/main.out b/cli/tests/testdata/npm/peer_deps_with_copied_folders/main.out
index ce0dc6896..32fa3b76f 100644
--- a/cli/tests/testdata/npm/peer_deps_with_copied_folders/main.out
+++ b/cli/tests/testdata/npm/peer_deps_with_copied_folders/main.out
@@ -1,10 +1,14 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-child
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-grandchild
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-peer
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-child/1.0.0.tgz
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-child/2.0.0.tgz
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-grandchild/1.0.0.tgz
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-peer/1.0.0.tgz
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-peer/2.0.0.tgz
+[UNORDERED_END]
 1
 2
diff --git a/cli/tests/testdata/npm/peer_deps_with_copied_folders/main_node_modules.out b/cli/tests/testdata/npm/peer_deps_with_copied_folders/main_node_modules.out
index 6cbadb8e7..02b5cbafd 100644
--- a/cli/tests/testdata/npm/peer_deps_with_copied_folders/main_node_modules.out
+++ b/cli/tests/testdata/npm/peer_deps_with_copied_folders/main_node_modules.out
@@ -1,7 +1,9 @@
+[UNORDERED_START]
 Initialize @denotest/peer-dep-test-child@1.0.0
 Initialize @denotest/peer-dep-test-child@2.0.0
 Initialize @denotest/peer-dep-test-grandchild@1.0.0
 Initialize @denotest/peer-dep-test-peer@1.0.0
 Initialize @denotest/peer-dep-test-peer@2.0.0
+[UNORDERED_END]
 1
 2
diff --git a/cli/tests/testdata/npm/peer_deps_with_copied_folders/main_node_modules_reload.out b/cli/tests/testdata/npm/peer_deps_with_copied_folders/main_node_modules_reload.out
index 91a59e183..ed73c6cc2 100644
--- a/cli/tests/testdata/npm/peer_deps_with_copied_folders/main_node_modules_reload.out
+++ b/cli/tests/testdata/npm/peer_deps_with_copied_folders/main_node_modules_reload.out
@@ -1,6 +1,9 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-child
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-grandchild
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-peer
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-child/1.0.0.tgz
 Initialize @denotest/peer-dep-test-child@1.0.0
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-child/2.0.0.tgz
@@ -11,5 +14,6 @@ Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-peer/1.0.0.t
 Initialize @denotest/peer-dep-test-peer@1.0.0
 Download http://localhost:4545/npm/registry/@denotest/peer-dep-test-peer/2.0.0.tgz
 Initialize @denotest/peer-dep-test-peer@2.0.0
+[UNORDERED_END]
 1
 2
diff --git a/cli/tests/testdata/npm/types_no_types_entry/main.out b/cli/tests/testdata/npm/types_no_types_entry/main.out
index 429940fff..059009d3f 100644
--- a/cli/tests/testdata/npm/types_no_types_entry/main.out
+++ b/cli/tests/testdata/npm/types_no_types_entry/main.out
@@ -1,7 +1,11 @@
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/types-no-types-entry
 Download http://localhost:4545/npm/registry/@denotest/types-entry-value-not-exists
+[UNORDERED_END]
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/types-entry-value-not-exists/1.0.0.tgz
 Download http://localhost:4545/npm/registry/@denotest/types-no-types-entry/1.0.0.tgz
+[UNORDERED_END]
 Check file://[WILDCARD]/types_no_types_entry/main.ts
 error: TS2322 [ERROR]: Type 'number' is not assignable to type 'string'.
 const result: string = getValue();
diff --git a/cli/tests/testdata/task/package_json/bin.out b/cli/tests/testdata/task/package_json/bin.out
index 6cfa06d43..5e04796eb 100644
--- a/cli/tests/testdata/task/package_json/bin.out
+++ b/cli/tests/testdata/task/package_json/bin.out
@@ -1,8 +1,10 @@
 Download http://localhost:4545/npm/registry/@denotest/bin
+[UNORDERED_START]
 Download http://localhost:4545/npm/registry/@denotest/bin/0.5.0.tgz
 Initialize @denotest/bin@0.5.0
 Download http://localhost:4545/npm/registry/@denotest/bin/1.0.0.tgz
 Initialize @denotest/bin@1.0.0
+[UNORDERED_END]
 Warning Currently only basic package.json `scripts` are supported. Programs like `rimraf` or `cross-env` will not work correctly. This will be fixed in an upcoming release.
 Task bin @denotest/bin hi && cli-esm testing this out && npx cli-cjs test "extra"
 hi