fix(npm): improved optional dependency support (#19135)

Note: If the package information has already been cached, then this
requires running with `--reload` or for the registry information to be
fetched some other way (ex. the cache busting).

Closes #15544

---------

Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>

9 files changed, 51 insertions, 0 deletions

diff --git a/cli/tests/testdata/npm/binary_package/main.js b/cli/tests/testdata/npm/binary_package/main.js
new file mode 100644
index 000000000..8823c5a5b
--- /dev/null
+++ b/cli/tests/testdata/npm/binary_package/main.js
@@ -0,0 +1 @@
+import "npm:@denotest/binary-package";
diff --git a/cli/tests/testdata/npm/registry/@denotest/binary-package-linux/1.0.0/index.js b/cli/tests/testdata/npm/registry/@denotest/binary-package-linux/1.0.0/index.js
new file mode 100644
index 000000000..03ecfc377
--- /dev/null
+++ b/cli/tests/testdata/npm/registry/@denotest/binary-package-linux/1.0.0/index.js
@@ -0,0 +1 @@
+console.log("Hello from binary package on linux");
\ No newline at end of file
diff --git a/cli/tests/testdata/npm/registry/@denotest/binary-package-linux/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/binary-package-linux/1.0.0/package.json
new file mode 100644
index 000000000..3b450e0d9
--- /dev/null
+++ b/cli/tests/testdata/npm/registry/@denotest/binary-package-linux/1.0.0/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@denotest/binary-package-linux",
+  "version": "1.0.0",
+  "main": "index.js",
+  "os": [
+    "linux"
+  ]
+}
diff --git a/cli/tests/testdata/npm/registry/@denotest/binary-package-mac/1.0.0/index.js b/cli/tests/testdata/npm/registry/@denotest/binary-package-mac/1.0.0/index.js
new file mode 100644
index 000000000..ac8c91f50
--- /dev/null
+++ b/cli/tests/testdata/npm/registry/@denotest/binary-package-mac/1.0.0/index.js
@@ -0,0 +1 @@
+console.log("Hello from binary package on mac");
\ No newline at end of file
diff --git a/cli/tests/testdata/npm/registry/@denotest/binary-package-mac/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/binary-package-mac/1.0.0/package.json
new file mode 100644
index 000000000..02916e65b
--- /dev/null
+++ b/cli/tests/testdata/npm/registry/@denotest/binary-package-mac/1.0.0/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@denotest/binary-package-linux",
+  "version": "1.0.0",
+  "main": "index.js",
+  "os": [
+    "darwin"
+  ]
+}
diff --git a/cli/tests/testdata/npm/registry/@denotest/binary-package-windows/1.0.0/index.js b/cli/tests/testdata/npm/registry/@denotest/binary-package-windows/1.0.0/index.js
new file mode 100644
index 000000000..57344ca00
--- /dev/null
+++ b/cli/tests/testdata/npm/registry/@denotest/binary-package-windows/1.0.0/index.js
@@ -0,0 +1 @@
+console.log("Hello from binary package on windows");
\ No newline at end of file
diff --git a/cli/tests/testdata/npm/registry/@denotest/binary-package-windows/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/binary-package-windows/1.0.0/package.json
new file mode 100644
index 000000000..1c0af637d
--- /dev/null
+++ b/cli/tests/testdata/npm/registry/@denotest/binary-package-windows/1.0.0/package.json
@@ -0,0 +1,8 @@
+{
+  "name": "@denotest/binary-package-windows",
+  "version": "1.0.0",
+  "main": "index.js",
+  "os": [
+    "win32"
+  ]
+}
diff --git a/cli/tests/testdata/npm/registry/@denotest/binary-package/1.0.0/index.js b/cli/tests/testdata/npm/registry/@denotest/binary-package/1.0.0/index.js
new file mode 100644
index 000000000..5870118e7
--- /dev/null
+++ b/cli/tests/testdata/npm/registry/@denotest/binary-package/1.0.0/index.js
@@ -0,0 +1,13 @@
+const packageByOs = {
+  "darwin": "@denotest/binary-package-mac",
+  "linux": "@denotest/binary-package-linux",
+  "win32": "@denotest/binary-package-windows",
+}
+
+const selectedPackage = packageByOs[process.platform];
+
+if (!selectedPackage) {
+  throw new Error("trying to run on unsupported platform");
+}
+
+require(selectedPackage);
\ No newline at end of file
diff --git a/cli/tests/testdata/npm/registry/@denotest/binary-package/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/binary-package/1.0.0/package.json
new file mode 100644
index 000000000..dc8859bb4
--- /dev/null
+++ b/cli/tests/testdata/npm/registry/@denotest/binary-package/1.0.0/package.json
@@ -0,0 +1,10 @@
+{
+  "name": "@denotest/binary-package",
+  "version": "1.0.0",
+  "main": "index.js",
+  "optionalDependencies": {
+    "@denotest/binary-package-linux": "1.0.0",
+    "@denotest/binary-package-mac": "1.0.0",
+    "@denotest/binary-package-windows": "1.0.0"
+  }
+}