diff options
| author | Bartek Iwańczuk <biwanczuk@gmail.com> | 2022-11-16 01:40:03 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-16 01:40:03 +0100 |
| commit | 300fd07fad3dee74730517ba91b2e7314632fc3f (patch) | |
| tree | 5af343873fecc859e5c62ad5eb2895c8f746e605 /cli/tests/testdata | |
| parent | 7aa8e9c0351eabe822916394942c576381a13c6c (diff) | |
fix(npm): don't fail if conditional exports don't contains types (#16651)
If resolving types for an npm package, we didn't find "types" entry in
the conditional exports declaration we were falling-through to regular
resolution, instead of short-circuiting and giving up on resolving
types, which might lead to unwarranted errors.
Closes https://github.com/denoland/deno/issues/16649
Diffstat (limited to 'cli/tests/testdata')
5 files changed, 27 insertions, 0 deletions
diff --git a/cli/tests/testdata/npm/no_types_in_conditional_exports/main.out b/cli/tests/testdata/npm/no_types_in_conditional_exports/main.out new file mode 100644 index 000000000..7d574aed2 --- /dev/null +++ b/cli/tests/testdata/npm/no_types_in_conditional_exports/main.out @@ -0,0 +1,5 @@ +Download http://localhost:4545/npm/registry/@denotest/no-types-in-conditional-exports +Download http://localhost:4545/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0.tgz +Check [WILDCARD]npm/no_types_in_conditional_exports/main.ts +[WILDCARD] +{ foo: "bar" } diff --git a/cli/tests/testdata/npm/no_types_in_conditional_exports/main.ts b/cli/tests/testdata/npm/no_types_in_conditional_exports/main.ts new file mode 100644 index 000000000..7ec2f18fd --- /dev/null +++ b/cli/tests/testdata/npm/no_types_in_conditional_exports/main.ts @@ -0,0 +1,2 @@ +import foo from "npm:@denotest/no-types-in-conditional-exports@1.0.0"; +console.log(foo); diff --git a/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo-esm.js b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo-esm.js new file mode 100644 index 000000000..0ead93520 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo-esm.js @@ -0,0 +1,3 @@ +export default { + "foo": "bar" +};
\ No newline at end of file diff --git a/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo.js b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo.js new file mode 100644 index 000000000..dca03a472 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/lib/foo.js @@ -0,0 +1,3 @@ +module.exports = { + "foo": "bar" +};
\ No newline at end of file diff --git a/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/package.json b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/package.json new file mode 100644 index 000000000..524394480 --- /dev/null +++ b/cli/tests/testdata/npm/registry/@denotest/no-types-in-conditional-exports/1.0.0/package.json @@ -0,0 +1,14 @@ +{ + "name": "@denotest/no-types-in-conditional-exports", + "version": "1.0.0", + "main": "./lib/foo.js", + "module": "./lib/foo-esm.js", + "exports": { + ".": { + "require": "./lib/foo.js", + "import": "./lib/foo-esm.js" + }, + "./*": "./*" + }, + "type": "module" +} |