diff options
| author | Luca Casonato <hello@lcas.dev> | 2023-07-19 10:30:04 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-19 10:30:04 +0200 |
| commit | e511022c7445cc22193edb1626c77d9674935425 (patch) | |
| tree | 521b30eac14cd19a506c9cdfa52cde1da7211dcf /cli/tests/testdata/run/with_package_json | |
| parent | bf4e99cbd77087706e7ea7034bd90079c2218e2b (diff) | |
feat(ext/node): properly segregate node globals (#19307)
Code run within Deno-mode and Node-mode should have access to a
slightly different set of globals. Previously this was done through a
compile time code-transform for Node-mode, but this is not ideal and has
many edge cases, for example Node's globalThis having a different
identity than Deno's globalThis.
This commit makes the `globalThis` of the entire runtime a semi-proxy.
This proxy returns a different set of globals depending on the caller's
mode. This is not a full proxy, because it is shadowed by "real"
properties on globalThis. This is done to avoid the overhead of a full
proxy for all globalThis operations.
The globals between Deno-mode and Node-mode are now properly segregated.
This means that code running in Deno-mode will not have access to Node's
globals, and vice versa. Deleting a managed global in Deno-mode will
NOT delete the corresponding global in Node-mode, and vice versa.
---------
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Co-authored-by: Aapo Alasuutari <aapo.alasuutari@gmail.com>
Diffstat (limited to 'cli/tests/testdata/run/with_package_json')
| -rw-r--r-- | cli/tests/testdata/run/with_package_json/npm_binary/main.out | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/cli/tests/testdata/run/with_package_json/npm_binary/main.out b/cli/tests/testdata/run/with_package_json/npm_binary/main.out index 56cdae6f9..9e8e87bae 100644 --- a/cli/tests/testdata/run/with_package_json/npm_binary/main.out +++ b/cli/tests/testdata/run/with_package_json/npm_binary/main.out @@ -1,6 +1,9 @@ [WILDCARD]package.json file found at '[WILDCARD]with_package_json[WILDCARD]npm_binary[WILDCARD]package.json' [WILDCARD] this +[WILDCARD] is +[WILDCARD] a +[WILDCARD] test |