summaryrefslogtreecommitdiff
path: root/cli/tests/testdata/run/unhandled_rejection_dynamic_import
diff options
context:
space:
mode:
authorBartek IwaƄczuk <biwanczuk@gmail.com>2022-12-23 19:46:24 +0100
committerGitHub <noreply@github.com>2022-12-23 19:46:24 +0100
commit208c91b68f4ae1b59e65acbde3de729e7058bb5e (patch)
treeaa0faab20715baee85b571b151426bf832231eb7 /cli/tests/testdata/run/unhandled_rejection_dynamic_import
parent2a61b5fdd444c4b6f47f0e0bfbafe0bd26789d68 (diff)
fix(core): run macrotasks and next ticks after polling dynamic imports (#17173)
This commit fixes handling of rejected promises in dynamic imports evaluation. Previously we were running callbacks for next ticks and macrotasks _before_ polling dynamic imports and checked for unhandled rejections immediately after. This is wrong, as `unhandledrejection` event is dispatched and its callbacks are run as macrotasks. This commit changes order of actions performed by the event loop to following: - poll async ops - poll dynamic imports - run next tick callbacks - run macrotask callbacks - check for unhandled promise rejections
Diffstat (limited to 'cli/tests/testdata/run/unhandled_rejection_dynamic_import')
-rw-r--r--cli/tests/testdata/run/unhandled_rejection_dynamic_import/import.ts5
-rw-r--r--cli/tests/testdata/run/unhandled_rejection_dynamic_import/main.ts1
-rw-r--r--cli/tests/testdata/run/unhandled_rejection_dynamic_import/main.ts.out3
3 files changed, 9 insertions, 0 deletions
diff --git a/cli/tests/testdata/run/unhandled_rejection_dynamic_import/import.ts b/cli/tests/testdata/run/unhandled_rejection_dynamic_import/import.ts
new file mode 100644
index 000000000..b490f2c20
--- /dev/null
+++ b/cli/tests/testdata/run/unhandled_rejection_dynamic_import/import.ts
@@ -0,0 +1,5 @@
+globalThis.addEventListener("unhandledrejection", () => {
+ console.log("hey");
+});
+console.log("---");
+Promise.reject();
diff --git a/cli/tests/testdata/run/unhandled_rejection_dynamic_import/main.ts b/cli/tests/testdata/run/unhandled_rejection_dynamic_import/main.ts
new file mode 100644
index 000000000..244d84467
--- /dev/null
+++ b/cli/tests/testdata/run/unhandled_rejection_dynamic_import/main.ts
@@ -0,0 +1 @@
+await import("./import.ts");
diff --git a/cli/tests/testdata/run/unhandled_rejection_dynamic_import/main.ts.out b/cli/tests/testdata/run/unhandled_rejection_dynamic_import/main.ts.out
new file mode 100644
index 000000000..f44c6d2ff
--- /dev/null
+++ b/cli/tests/testdata/run/unhandled_rejection_dynamic_import/main.ts.out
@@ -0,0 +1,3 @@
+---
+hey
+error: Uncaught (in promise) undefined