summaryrefslogtreecommitdiff
path: root/cli/tests/testdata/lsp
diff options
context:
space:
mode:
authorBartek IwaƄczuk <biwanczuk@gmail.com>2022-12-29 21:07:09 +0100
committerGitHub <noreply@github.com>2022-12-29 21:07:09 +0100
commitef5f8cd265b4bf161832ee23abfbe10605cf5b67 (patch)
tree4ca4542fec2a89b59ccbf2d1aeb2398d493227e4 /cli/tests/testdata/lsp
parent65ea554afe1ce387ea1d663e6178079ebcf0904f (diff)
fix(lsp): "Add all missing imports" uses correct specifiers (#17216)
This commit fixes "Add all missing imports" quick fix; before it was replacing all occurrences with the same specifier. Now every line returned from TSC is processed individually.
Diffstat (limited to 'cli/tests/testdata/lsp')
-rw-r--r--cli/tests/testdata/lsp/code_action_params_imports.json30
-rw-r--r--cli/tests/testdata/lsp/code_action_resolve_params_imports.json28
-rw-r--r--cli/tests/testdata/lsp/code_action_resolve_response_imports.json32
-rw-r--r--cli/tests/testdata/lsp/code_action_response_imports.json44
4 files changed, 83 insertions, 51 deletions
diff --git a/cli/tests/testdata/lsp/code_action_params_imports.json b/cli/tests/testdata/lsp/code_action_params_imports.json
index 7a5824923..891257ca0 100644
--- a/cli/tests/testdata/lsp/code_action_params_imports.json
+++ b/cli/tests/testdata/lsp/code_action_params_imports.json
@@ -1,15 +1,15 @@
{
"textDocument": {
- "uri": "file:///a/file01.ts"
+ "uri": "file:///a/file00.ts"
},
"range": {
"start": {
- "line": 1,
- "character": 12
+ "line": 0,
+ "character": 0
},
"end": {
- "line": 1,
- "character": 15
+ "line": 6,
+ "character": 0
}
},
"context": {
@@ -17,34 +17,34 @@
{
"range": {
"start": {
- "line": 1,
- "character": 12
+ "line": 0,
+ "character": 50
},
"end": {
- "line": 1,
- "character": 15
+ "line": 0,
+ "character": 67
}
},
"severity": 1,
"code": 2304,
"source": "deno-ts",
- "message": "Cannot find name 'abc'."
+ "message": "Cannot find name 'DuckConfigOptions'."
},
{
"range": {
"start": {
- "line": 2,
- "character": 12
+ "line": 4,
+ "character": 39
},
"end": {
- "line": 2,
- "character": 15
+ "line": 4,
+ "character": 49
}
},
"severity": 1,
"code": 2304,
"source": "deno-ts",
- "message": "Cannot find name 'def'."
+ "message": "Cannot find name 'DuckConfig'."
}
],
"only": [
diff --git a/cli/tests/testdata/lsp/code_action_resolve_params_imports.json b/cli/tests/testdata/lsp/code_action_resolve_params_imports.json
index 60178bbfe..5e1beb87b 100644
--- a/cli/tests/testdata/lsp/code_action_resolve_params_imports.json
+++ b/cli/tests/testdata/lsp/code_action_resolve_params_imports.json
@@ -5,22 +5,38 @@
{
"range": {
"start": {
- "line": 1,
- "character": 12
+ "line": 0,
+ "character": 50
},
"end": {
- "line": 1,
- "character": 15
+ "line": 0,
+ "character": 67
}
},
"severity": 1,
"code": 2304,
"source": "deno-ts",
- "message": "Cannot find name 'abc'."
+ "message": "Cannot find name 'DuckConfigOptions'."
+ },
+ {
+ "range": {
+ "start": {
+ "line": 4,
+ "character": 39
+ },
+ "end": {
+ "line": 4,
+ "character": 49
+ }
+ },
+ "severity": 1,
+ "code": 2304,
+ "source": "deno-ts",
+ "message": "Cannot find name 'DuckConfig'."
}
],
"data": {
- "specifier": "file:///a/file01.ts",
+ "specifier": "file:///a/file00.ts",
"fixId": "fixMissingImport"
}
}
diff --git a/cli/tests/testdata/lsp/code_action_resolve_response_imports.json b/cli/tests/testdata/lsp/code_action_resolve_response_imports.json
index 6621c501f..6ffc3192e 100644
--- a/cli/tests/testdata/lsp/code_action_resolve_response_imports.json
+++ b/cli/tests/testdata/lsp/code_action_resolve_response_imports.json
@@ -5,25 +5,41 @@
{
"range": {
"start": {
- "line": 1,
- "character": 12
+ "line": 0,
+ "character": 50
},
"end": {
- "line": 1,
- "character": 15
+ "line": 0,
+ "character": 67
}
},
"severity": 1,
"code": 2304,
"source": "deno-ts",
- "message": "Cannot find name 'abc'."
+ "message": "Cannot find name 'DuckConfigOptions'."
+ },
+ {
+ "range": {
+ "start": {
+ "line": 4,
+ "character": 39
+ },
+ "end": {
+ "line": 4,
+ "character": 49
+ }
+ },
+ "severity": 1,
+ "code": 2304,
+ "source": "deno-ts",
+ "message": "Cannot find name 'DuckConfig'."
}
],
"edit": {
"documentChanges": [
{
"textDocument": {
- "uri": "file:///a/file01.ts",
+ "uri": "file:///a/file00.ts",
"version": 1
},
"edits": [
@@ -38,14 +54,14 @@
"character": 0
}
},
- "newText": "import { abc,def } from \"./file00.ts\";\n"
+ "newText": "import { DuckConfig } from \"./file01.ts\";\nimport { DuckConfigOptions } from \"./file02.ts\";\n\n"
}
]
}
]
},
"data": {
- "specifier": "file:///a/file01.ts",
+ "specifier": "file:///a/file00.ts",
"fixId": "fixMissingImport"
}
}
diff --git a/cli/tests/testdata/lsp/code_action_response_imports.json b/cli/tests/testdata/lsp/code_action_response_imports.json
index 4bbbb9c75..23eb6645d 100644
--- a/cli/tests/testdata/lsp/code_action_response_imports.json
+++ b/cli/tests/testdata/lsp/code_action_response_imports.json
@@ -1,30 +1,30 @@
[
{
- "title": "Add import from \"./file00.ts\"",
+ "title": "Add import from \"./file02.ts\"",
"kind": "quickfix",
"diagnostics": [
{
"range": {
"start": {
- "line": 1,
- "character": 12
+ "line": 0,
+ "character": 50
},
"end": {
- "line": 1,
- "character": 15
+ "line": 0,
+ "character": 67
}
},
"severity": 1,
"code": 2304,
"source": "deno-ts",
- "message": "Cannot find name 'abc'."
+ "message": "Cannot find name 'DuckConfigOptions'."
}
],
"edit": {
"documentChanges": [
{
"textDocument": {
- "uri": "file:///a/file01.ts",
+ "uri": "file:///a/file00.ts",
"version": 1
},
"edits": [
@@ -39,7 +39,7 @@
"character": 0
}
},
- "newText": "import { abc } from \"./file00.ts\";\n"
+ "newText": "import { DuckConfigOptions } from \"./file02.ts\";\n\n"
}
]
}
@@ -53,51 +53,51 @@
{
"range": {
"start": {
- "line": 1,
- "character": 12
+ "line": 0,
+ "character": 50
},
"end": {
- "line": 1,
- "character": 15
+ "line": 0,
+ "character": 67
}
},
"severity": 1,
"code": 2304,
"source": "deno-ts",
- "message": "Cannot find name 'abc'."
+ "message": "Cannot find name 'DuckConfigOptions'."
}
],
"data": {
- "specifier": "file:///a/file01.ts",
+ "specifier": "file:///a/file00.ts",
"fixId": "fixMissingImport"
}
},
{
- "title": "Add import from \"./file00.ts\"",
+ "title": "Add import from \"./file01.ts\"",
"kind": "quickfix",
"diagnostics": [
{
"range": {
"start": {
- "line": 2,
- "character": 12
+ "line": 4,
+ "character": 39
},
"end": {
- "line": 2,
- "character": 15
+ "line": 4,
+ "character": 49
}
},
"severity": 1,
"code": 2304,
"source": "deno-ts",
- "message": "Cannot find name 'def'."
+ "message": "Cannot find name 'DuckConfig'."
}
],
"edit": {
"documentChanges": [
{
"textDocument": {
- "uri": "file:///a/file01.ts",
+ "uri": "file:///a/file00.ts",
"version": 1
},
"edits": [
@@ -112,7 +112,7 @@
"character": 0
}
},
- "newText": "import { def } from \"./file00.ts\";\n"
+ "newText": "import { DuckConfig } from \"./file01.ts\";\n\n"
}
]
}