diff options
| author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2020-03-03 18:22:53 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-03 18:22:53 +0100 |
| commit | ee452ad883c1c711839655a307b39e8eea5bf410 (patch) | |
| tree | 2812a5201beb2b52c92d6e3c958f2288b0253b68 /cli/tests/subdir | |
| parent | 4dc004f0a24fdc81026ec03326b9943a95f1a31d (diff) | |
add assertOps sanitizer in cli/js/ unit tests (#4209)
* add "assertOps" test assertion which makes sure test case
is not "leaking" ops - ie. after test finishes there are no
pending async ops
* apply "assertOps" to all tests in "cli/js/"
* fix numerous tests leaking ops
* document problem with edge case in "clearInterval"
and "clearTimeout" implementation where they
may leak async ops
* move "cli/js/worker_test.ts" to "cli/tests/worker_test.ts" and
run as integration test; workers leak ops because of missing
"terminate" implementation
Diffstat (limited to 'cli/tests/subdir')
| -rw-r--r-- | cli/tests/subdir/nested_worker.js | 1 | ||||
| -rw-r--r-- | cli/tests/subdir/test_worker.js | 3 | ||||
| -rw-r--r-- | cli/tests/subdir/test_worker.ts | 1 | ||||
| -rw-r--r-- | cli/tests/subdir/test_worker_basic.js | 2 |
4 files changed, 0 insertions, 7 deletions
diff --git a/cli/tests/subdir/nested_worker.js b/cli/tests/subdir/nested_worker.js index b0acd70d7..a4eed723a 100644 --- a/cli/tests/subdir/nested_worker.js +++ b/cli/tests/subdir/nested_worker.js @@ -9,7 +9,6 @@ jsWorker.onerror = _e => { }; jsWorker.onmessage = e => { - console.log("js worker on message"); postMessage({ type: "msg", text: e }); close(); }; diff --git a/cli/tests/subdir/test_worker.js b/cli/tests/subdir/test_worker.js index 70e1d8b73..9c1e555b5 100644 --- a/cli/tests/subdir/test_worker.js +++ b/cli/tests/subdir/test_worker.js @@ -5,8 +5,6 @@ if (self.name !== "jsWorker") { } onmessage = function(e) { - console.log(e.data); - if (thrown === false) { thrown = true; throw new SyntaxError("[test error]"); @@ -17,6 +15,5 @@ onmessage = function(e) { }; onerror = function() { - console.log("called onerror in worker"); return false; }; diff --git a/cli/tests/subdir/test_worker.ts b/cli/tests/subdir/test_worker.ts index 2ea8f9214..1f924c073 100644 --- a/cli/tests/subdir/test_worker.ts +++ b/cli/tests/subdir/test_worker.ts @@ -3,7 +3,6 @@ if (self.name !== "tsWorker") { } onmessage = function(e): void { - console.log(e.data); postMessage(e.data); close(); }; diff --git a/cli/tests/subdir/test_worker_basic.js b/cli/tests/subdir/test_worker_basic.js index db00b6d0c..aef1658c0 100644 --- a/cli/tests/subdir/test_worker_basic.js +++ b/cli/tests/subdir/test_worker_basic.js @@ -6,12 +6,10 @@ if (self.name !== "jsWorker") { } onmessage = function(e) { - console.log("jsWorker onmessage", e.data); postMessage(e.data); close(); }; onerror = function() { - console.log("called onerror in worker"); return false; }; |
