summaryrefslogtreecommitdiff
path: root/cli/tests/node_compat
diff options
context:
space:
mode:
authorBartek IwaƄczuk <biwanczuk@gmail.com>2023-05-24 00:11:37 +0200
committerGitHub <noreply@github.com>2023-05-24 00:11:37 +0200
commit01a95d677f897776e6478ef6c728f85a8d44002c (patch)
tree04bf2f01112ab48ca20cb04c7a524fc68b62e697 /cli/tests/node_compat
parent26f42a248f4764f85c1c3c3c511b82a990e4b651 (diff)
chore: upgrade rusty_v8 to 0.72.0 (#19228)
This commit updates rusty_v8 to 0.72.0 and by extension V8 to version 11.5.150.1.
Diffstat (limited to 'cli/tests/node_compat')
-rw-r--r--cli/tests/node_compat/test.ts7
1 files changed, 7 insertions, 0 deletions
diff --git a/cli/tests/node_compat/test.ts b/cli/tests/node_compat/test.ts
index 17c5bd029..52bb6810c 100644
--- a/cli/tests/node_compat/test.ts
+++ b/cli/tests/node_compat/test.ts
@@ -66,9 +66,15 @@ async function runTest(t: Deno.TestContext, path: string): Promise<void> {
const v8Flags = ["--stack-size=4000"];
const testSource = await Deno.readTextFile(testCase);
+ const envVars: Record<string, string> = {};
// TODO(kt3k): Parse `Flags` directive correctly
if (testSource.includes("Flags: --expose_externalize_string")) {
v8Flags.push("--expose-externalize-string");
+ // TODO(bartlomieju): disable verifying globals if that V8 flag is
+ // present. Even though we should be able to pass a list of globals
+ // that are allowed, it doesn't work, because the list is expected to
+ // contain actual JS objects, not strings :)).
+ envVars["NODE_TEST_KNOWN_GLOBALS"] = "0";
}
const args = [
@@ -88,6 +94,7 @@ async function runTest(t: Deno.TestContext, path: string): Promise<void> {
args,
env: {
TEST_SERIAL_ID: String(testSerialId++),
+ ...envVars,
},
cwd,
});