diff options
author | Matt Mastracci <matthew@mastracci.com> | 2024-02-10 13:22:13 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-02-10 20:22:13 +0000 |
commit | f5e46c9bf2f50d66a953fa133161fc829cecff06 (patch) | |
tree | 8faf2f5831c1c7b11d842cd9908d141082c869a5 /cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js | |
parent | d2477f780630a812bfd65e3987b70c0d309385bb (diff) |
chore: move cli/tests/ -> tests/ (#22369)
This looks like a massive PR, but it's only a move from cli/tests ->
tests, and updates of relative paths for files.
This is the first step towards aggregate all of the integration test
files under tests/, which will lead to a set of integration tests that
can run without the CLI binary being built.
While we could leave these tests under `cli`, it would require us to
keep a more complex directory structure for the various test runners. In
addition, we have a lot of complexity to ignore various test files in
the `cli` project itself (cargo publish exclusion rules, autotests =
false, etc).
And finally, the `tests/` folder will eventually house the `test_ffi`,
`test_napi` and other testing code, reducing the size of the root repo
directory.
For easier review, the extremely large and noisy "move" is in the first
commit (with no changes -- just a move), while the remainder of the
changes to actual files is in the second commit.
Diffstat (limited to 'cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js')
-rw-r--r-- | cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js | 65 |
1 files changed, 0 insertions, 65 deletions
diff --git a/cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js b/cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js deleted file mode 100644 index 4a8c7ab0d..000000000 --- a/cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js +++ /dev/null @@ -1,65 +0,0 @@ -// deno-fmt-ignore-file -// deno-lint-ignore-file - -// Copyright Joyent and Node contributors. All rights reserved. MIT license. -// Taken from Node 18.12.1 -// This file is automatically generated by `tools/node_compat/setup.ts`. Do not modify this file manually. - -'use strict'; -// This test was originally written to test a regression -// that was introduced by -// https://github.com/nodejs/node/pull/2288#issuecomment-179543894 -require('../common'); - -const assert = require('assert'); -const parse = require('querystring').parse; - -// Taken from express-js/body-parser -// https://github.com/expressjs/body-parser/blob/ed25264fb494cf0c8bc992b8257092cd4f694d5e/test/urlencoded.js#L636-L651 -function createManyParams(count) { - let str = ''; - - if (count === 0) { - return str; - } - - str += '0=0'; - - for (let i = 1; i < count; i++) { - const n = i.toString(36); - str += `&${n}=${n}`; - } - - return str; -} - -const count = 10000; -const originalMaxLength = 1000; -const params = createManyParams(count); - -// thealphanerd -// 27def4f introduced a change to parse that would cause Infinity -// to be passed to String.prototype.split as an argument for limit -// In this instance split will always return an empty array -// this test confirms that the output of parse is the expected length -// when passed Infinity as the argument for maxKeys -const resultInfinity = parse(params, undefined, undefined, { - maxKeys: Infinity -}); -const resultNaN = parse(params, undefined, undefined, { - maxKeys: NaN -}); -const resultInfinityString = parse(params, undefined, undefined, { - maxKeys: 'Infinity' -}); -const resultNaNString = parse(params, undefined, undefined, { - maxKeys: 'NaN' -}); - -// Non Finite maxKeys should return the length of input -assert.strictEqual(Object.keys(resultInfinity).length, count); -assert.strictEqual(Object.keys(resultNaN).length, count); -// Strings maxKeys should return the maxLength -// defined by parses internals -assert.strictEqual(Object.keys(resultInfinityString).length, originalMaxLength); -assert.strictEqual(Object.keys(resultNaNString).length, originalMaxLength); |