summaryrefslogtreecommitdiff
path: root/cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js
diff options
context:
space:
mode:
authorYoshiya Hinosawa <stibium121@gmail.com>2023-02-21 00:35:04 +0900
committerGitHub <noreply@github.com>2023-02-20 16:35:04 +0100
commit6915a9b7a701dde0e1078867961c9a91811c1850 (patch)
treee6822f2b8400c7c7941d3cb9ace59842389b5bc9 /cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js
parenta1cd2a5915c13f6a9b8eafa3807e143a02616bc1 (diff)
test(ext/node): more node compat tests (#17827)
This PR adds the remaining ~650 Node.js compat test cases from std/node. Among these 650 cases, about 130 cases are now failing. These failing cases are prefixed with `TODO:` in `tests/node_compat/config.json`. These will be addressed in later PRs.
Diffstat (limited to 'cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js')
-rw-r--r--cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js65
1 files changed, 65 insertions, 0 deletions
diff --git a/cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js b/cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js
new file mode 100644
index 000000000..c87889853
--- /dev/null
+++ b/cli/tests/node_compat/test/parallel/test-querystring-maxKeys-non-finite.js
@@ -0,0 +1,65 @@
+// deno-fmt-ignore-file
+// deno-lint-ignore-file
+
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+// Taken from Node 18.12.1
+// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
+
+'use strict';
+// This test was originally written to test a regression
+// that was introduced by
+// https://github.com/nodejs/node/pull/2288#issuecomment-179543894
+require('../common');
+
+const assert = require('assert');
+const parse = require('querystring').parse;
+
+// Taken from express-js/body-parser
+// https://github.com/expressjs/body-parser/blob/ed25264fb494cf0c8bc992b8257092cd4f694d5e/test/urlencoded.js#L636-L651
+function createManyParams(count) {
+ let str = '';
+
+ if (count === 0) {
+ return str;
+ }
+
+ str += '0=0';
+
+ for (let i = 1; i < count; i++) {
+ const n = i.toString(36);
+ str += `&${n}=${n}`;
+ }
+
+ return str;
+}
+
+const count = 10000;
+const originalMaxLength = 1000;
+const params = createManyParams(count);
+
+// thealphanerd
+// 27def4f introduced a change to parse that would cause Infinity
+// to be passed to String.prototype.split as an argument for limit
+// In this instance split will always return an empty array
+// this test confirms that the output of parse is the expected length
+// when passed Infinity as the argument for maxKeys
+const resultInfinity = parse(params, undefined, undefined, {
+ maxKeys: Infinity
+});
+const resultNaN = parse(params, undefined, undefined, {
+ maxKeys: NaN
+});
+const resultInfinityString = parse(params, undefined, undefined, {
+ maxKeys: 'Infinity'
+});
+const resultNaNString = parse(params, undefined, undefined, {
+ maxKeys: 'NaN'
+});
+
+// Non Finite maxKeys should return the length of input
+assert.strictEqual(Object.keys(resultInfinity).length, count);
+assert.strictEqual(Object.keys(resultNaN).length, count);
+// Strings maxKeys should return the maxLength
+// defined by parses internals
+assert.strictEqual(Object.keys(resultInfinityString).length, originalMaxLength);
+assert.strictEqual(Object.keys(resultNaNString).length, originalMaxLength);