summaryrefslogtreecommitdiff
path: root/cli/tests/node_compat/test/parallel/test-http-outgoing-finish-writable.js
diff options
context:
space:
mode:
authorYoshiya Hinosawa <stibium121@gmail.com>2023-02-21 00:35:04 +0900
committerGitHub <noreply@github.com>2023-02-20 16:35:04 +0100
commit6915a9b7a701dde0e1078867961c9a91811c1850 (patch)
treee6822f2b8400c7c7941d3cb9ace59842389b5bc9 /cli/tests/node_compat/test/parallel/test-http-outgoing-finish-writable.js
parenta1cd2a5915c13f6a9b8eafa3807e143a02616bc1 (diff)
test(ext/node): more node compat tests (#17827)
This PR adds the remaining ~650 Node.js compat test cases from std/node. Among these 650 cases, about 130 cases are now failing. These failing cases are prefixed with `TODO:` in `tests/node_compat/config.json`. These will be addressed in later PRs.
Diffstat (limited to 'cli/tests/node_compat/test/parallel/test-http-outgoing-finish-writable.js')
-rw-r--r--cli/tests/node_compat/test/parallel/test-http-outgoing-finish-writable.js47
1 files changed, 47 insertions, 0 deletions
diff --git a/cli/tests/node_compat/test/parallel/test-http-outgoing-finish-writable.js b/cli/tests/node_compat/test/parallel/test-http-outgoing-finish-writable.js
new file mode 100644
index 000000000..f87a1130c
--- /dev/null
+++ b/cli/tests/node_compat/test/parallel/test-http-outgoing-finish-writable.js
@@ -0,0 +1,47 @@
+// deno-fmt-ignore-file
+// deno-lint-ignore-file
+
+// Copyright Joyent and Node contributors. All rights reserved. MIT license.
+// Taken from Node 18.12.1
+// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
+
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const http = require('http');
+
+// Verify that after calling end() on an `OutgoingMessage` (or a type that
+// inherits from `OutgoingMessage`), its `writable` property is not set to false
+
+const server = http.createServer(common.mustCall(function(req, res) {
+ assert.strictEqual(res.writable, true);
+ assert.strictEqual(res.finished, false);
+ assert.strictEqual(res.writableEnded, false);
+ res.end();
+
+ // res.writable is set to false after it has finished sending
+ // Ref: https://github.com/nodejs/node/issues/15029
+ assert.strictEqual(res.writable, true);
+ assert.strictEqual(res.finished, true);
+ assert.strictEqual(res.writableEnded, true);
+
+ server.close();
+}));
+
+server.listen(0);
+
+server.on('listening', common.mustCall(function() {
+ const clientRequest = http.request({
+ port: server.address().port,
+ method: 'GET',
+ path: '/'
+ });
+
+ assert.strictEqual(clientRequest.writable, true);
+ clientRequest.end();
+
+ // Writable is still true when close
+ // THIS IS LEGACY, we cannot change it
+ // unless we break error detection
+ assert.strictEqual(clientRequest.writable, true);
+}));