summaryrefslogtreecommitdiff
path: root/cli/tests/node_compat/test/parallel/test-http-outgoing-buffer.js
diff options
context:
space:
mode:
authorAndreu Botella <andreu@andreubotella.com>2023-05-16 17:49:35 +0200
committerGitHub <noreply@github.com>2023-05-16 17:49:35 +0200
commit9ba2c4c42fcbadea1f19c67c88b5cbc4c97804f3 (patch)
tree4cd2d0eb702251736af4ca6b9c86bc49ac4a5bf8 /cli/tests/node_compat/test/parallel/test-http-outgoing-buffer.js
parent1c74b41855b85c9ec2ee1d83ac0f6b04e1461788 (diff)
fix(fetch): Correctly decode `multipart/form-data` names and filenames (#19145)
Currently the `multipart/form-data` parser in `Request.prototype.formData` and `Response.prototype.formData` decodes non-ASCII filenames incorrectly, as if they were encoded in Latin-1 rather than UTF-8. This happens because the header section of each `multipart/form-data` entry is decoded as Latin-1 in order to be parsed with `Headers`, which only allows `ByteString`s, but the names and filenames are never decoded correctly. This PR fixes this as a post-processing step. Note that the `multipart/form-data` parsing for this APIs in the Fetch spec is very much underspecified, and it does not specify that names and filenames must be decoded as UTF-8. However, it does require that the bodies of non-`File` entries are decoded as UTF-8, and in browsers, names and filenames always use the same encoding as the body. Closes #19142.
Diffstat (limited to 'cli/tests/node_compat/test/parallel/test-http-outgoing-buffer.js')
0 files changed, 0 insertions, 0 deletions