diff options
| author | Yoshiya Hinosawa <stibium121@gmail.com> | 2023-02-21 00:35:04 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-20 16:35:04 +0100 |
| commit | 6915a9b7a701dde0e1078867961c9a91811c1850 (patch) | |
| tree | e6822f2b8400c7c7941d3cb9ace59842389b5bc9 /cli/tests/node_compat/test.ts | |
| parent | a1cd2a5915c13f6a9b8eafa3807e143a02616bc1 (diff) | |
test(ext/node): more node compat tests (#17827)
This PR adds the remaining ~650 Node.js compat test cases from std/node.
Among these 650 cases, about 130 cases are now failing. These failing
cases are prefixed with `TODO:` in `tests/node_compat/config.json`.
These will be addressed in later PRs.
Diffstat (limited to 'cli/tests/node_compat/test.ts')
| -rw-r--r-- | cli/tests/node_compat/test.ts | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/cli/tests/node_compat/test.ts b/cli/tests/node_compat/test.ts index 3af1fb693..4029596bd 100644 --- a/cli/tests/node_compat/test.ts +++ b/cli/tests/node_compat/test.ts @@ -39,9 +39,10 @@ for await (const path of testPaths) { ) { continue; } + const isTodo = path.includes("TODO"); const ignore = (Deno.build.os === "windows" && windowsIgnorePaths.has(path)) || - (Deno.build.os === "darwin" && darwinIgnorePaths.has(path)); + (Deno.build.os === "darwin" && darwinIgnorePaths.has(path)) || isTodo; Deno.test({ name: `Node.js compatibility "${path}"`, ignore, @@ -60,7 +61,7 @@ for await (const path of testPaths) { "-A", "--quiet", "--unstable", - "--unsafely-ignore-certificate-errors", + //"--unsafely-ignore-certificate-errors", "--v8-flags=" + v8Flags.join(), testCase.endsWith(".mjs") ? "--import-map=" + importMap : "runner.ts", testCase, @@ -94,7 +95,8 @@ for await (const path of testPaths) { } function checkConfigTestFilesOrder(testFileLists: Array<string[]>) { - for (const testFileList of testFileLists) { + for (let testFileList of testFileLists) { + testFileList = testFileList.filter((name) => !name.startsWith("TODO:")); const sortedTestList = JSON.parse(JSON.stringify(testFileList)); sortedTestList.sort(); if (JSON.stringify(testFileList) !== JSON.stringify(sortedTestList)) { |