diff options
| author | Andreu Botella <abb@randomunok.com> | 2021-10-10 07:03:23 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-10-10 16:03:23 +0200 |
| commit | 5edd2771619ddc3cd2f6c76cc93ee64277aa17c2 (patch) | |
| tree | 88307d65fc81388579328dfb7d3da782ffa3f5a9 /cli/tests/integration | |
| parent | 6ac0337165d5e341eee9bff9ff0065894289df69 (diff) | |
feat: Show the URL of streaming WASM modules in stack traces (#12268)
WebAssembly modules compiled through `WebAssembly.compile()` and similar
non-streaming APIs don't have a URL associated to them, because they
have been compiled from a buffer source. In stack traces, V8 will use
a URL such as `wasm://wasm/d1c677ea`, with a hash of the module.
However, wasm modules compiled through streaming APIs, like
`WebAssembly.compileStreaming()`, do have a known URL, which can be
obtained from the `Response` object passed into the streaming APIs. And
as per the developer-facing display conventions in the WebAssembly
Web API spec, this URL should be used in stack traces. This change
implements that.
Diffstat (limited to 'cli/tests/integration')
| -rw-r--r-- | cli/tests/integration/run_tests.rs | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/cli/tests/integration/run_tests.rs b/cli/tests/integration/run_tests.rs index 8c337b771..f247aa93f 100644 --- a/cli/tests/integration/run_tests.rs +++ b/cli/tests/integration/run_tests.rs @@ -856,11 +856,18 @@ itest!(wasm_async { }); itest!(wasm_unreachable { - args: "run wasm_unreachable.js", + args: "run --allow-read wasm_unreachable.js", output: "wasm_unreachable.out", exit_code: 1, }); +itest!(wasm_url { + args: "run --quiet --allow-net=localhost:4545 wasm_url.js", + output: "wasm_url.out", + exit_code: 1, + http_server: true, +}); + itest!(weakref { args: "run --quiet --reload weakref.ts", output: "weakref.ts.out", |
