chore(tests): test_util - Add `PathRef` (#19450)

This adds a new `PathRef` struct to test_util for making it easier to
work with paths in test code. I'm going to expand on this more in the
future.

1 files changed, 13 insertions, 39 deletions

diff --git a/cli/tests/integration/compile_tests.rs b/cli/tests/integration/compile_tests.rs
index c3a5048a1..022148ce4 100644
--- a/cli/tests/integration/compile_tests.rs
+++ b/cli/tests/integration/compile_tests.rs
@@ -1,7 +1,6 @@
 // Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
 
 use std::fs::File;
-use std::path::Path;
 use std::process::Command;
 use test_util as util;
 use test_util::TempDir;
@@ -30,37 +29,24 @@ fn compile_basic() {
       .run();
     output.assert_exit_code(0);
     output.skip_output_check();
-    let output = context
-      .new_command()
-      .command_name(exe.to_string_lossy())
-      .run();
+    let output = context.new_command().command_name(&exe).run();
     output.assert_matches_text("Welcome to Deno!\n");
   }
 
   // now ensure this works when the deno_dir is readonly
   let readonly_dir = dir.path().join("readonly");
-  make_dir_readonly(&readonly_dir);
+  readonly_dir.make_dir_readonly();
   let readonly_sub_dir = readonly_dir.join("sub");
 
   let output = context
     .new_command()
     // it should fail creating this, but still work
-    .env("DENO_DIR", readonly_sub_dir.to_string_lossy())
-    .command_name(exe.to_string_lossy())
+    .env("DENO_DIR", readonly_sub_dir)
+    .command_name(exe)
     .run();
   output.assert_matches_text("Welcome to Deno!\n");
 }
 
-fn make_dir_readonly(dir: &Path) {
-  std::fs::create_dir_all(dir).unwrap();
-  eprintln!("DIR: {}", dir.display());
-  if cfg!(windows) {
-    Command::new("attrib").arg("+r").arg(dir).output().unwrap();
-  } else if cfg!(unix) {
-    Command::new("chmod").arg("555").arg(dir).output().unwrap();
-  }
-}
-
 #[test]
 fn standalone_args() {
   let dir = TempDir::new();
@@ -272,7 +258,7 @@ fn compile_with_file_exists_error() {
       "is an existing file. You can use the `--output <file-path>` flag to ",
       "provide an alternative name.\n",
     ),
-    file_path.display(),
+    file_path,
   );
   let stderr = String::from_utf8(output.stderr).unwrap();
   assert_contains!(stderr, &expected_stderr);
@@ -305,7 +291,7 @@ fn compile_with_directory_exists_error() {
       "the same name. You can use the `--output <file-path>` flag to ",
       "provide an alternative name."
     ),
-    exe.display()
+    exe
   );
   let stderr = String::from_utf8(output.stderr).unwrap();
   assert_contains!(stderr, &expected_stderr);
@@ -338,7 +324,7 @@ fn compile_with_conflict_file_exists_error() {
       "and cannot be overwritten. Please delete the existing file or ",
       "use the `--output <file-path>` flag to provide an alternative name."
     ),
-    exe.display()
+    exe
   );
   let stderr = String::from_utf8(output.stderr).unwrap();
   assert_contains!(stderr, &expected_stderr);
@@ -704,7 +690,7 @@ fn workers_not_in_module_map() {
 
   let output = context
     .new_command()
-    .command_name(exe.to_string_lossy())
+    .command_name(exe)
     .env("NO_COLOR", "")
     .run();
   output.assert_exit_code(1);
@@ -842,10 +828,7 @@ fn compile_npm_specifiers() {
     output.assert_exit_code(0);
     output.skip_output_check();
 
-    let output = context
-      .new_command()
-      .command_name(binary_path.to_string_lossy())
-      .run();
+    let output = context.new_command().command_name(&binary_path).run();
     output.assert_matches_text(
       r#"Node esm importing node cjs
 ===========================
@@ -901,10 +884,7 @@ testing[WILDCARD]this
   output.assert_exit_code(0);
   output.skip_output_check();
 
-  let output = context
-    .new_command()
-    .command_name(binary_path.to_string_lossy())
-    .run();
+  let output = context.new_command().command_name(binary_path).run();
   output.assert_matches_text("2\n");
 }
 
@@ -1042,10 +1022,7 @@ fn run_npm_bin_compile_test(opts: RunNpmBinCompileOptions) {
   let main_specifier = if opts.input_specifier.starts_with("npm:") {
     opts.input_specifier.to_string()
   } else {
-    testdata_path
-      .join(opts.input_specifier)
-      .to_string_lossy()
-      .to_string()
+    testdata_path.join(opts.input_specifier).to_string()
   };
 
   let mut args = vec!["compile".to_string()];
@@ -1079,7 +1056,7 @@ fn run_npm_bin_compile_test(opts: RunNpmBinCompileOptions) {
   };
   let output = context
     .new_command()
-    .command_name(binary_path.to_string_lossy())
+    .command_name(binary_path)
     .args_vec(opts.run_args)
     .run();
   output.assert_matches_file(opts.output_file);
@@ -1144,9 +1121,6 @@ fn compile_node_modules_symlink_outside() {
   // run
   let binary_path =
     project_dir.join(if cfg!(windows) { "bin.exe" } else { "bin" });
-  let output = context
-    .new_command()
-    .command_name(binary_path.to_string_lossy())
-    .run();
+  let output = context.new_command().command_name(binary_path).run();
   output.assert_matches_file("compile/node_modules_symlink_outside/main.out");
 }