diff options
author | Luca Casonato <hello@lcas.dev> | 2021-07-20 21:06:24 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-07-20 21:06:24 +0200 |
commit | a2512de95f2e03008e631a7b19405317d8c361b8 (patch) | |
tree | 6ec8b1bff9d5c48ade49894073cc4728a0d5d0d6 /cli/tests/fetch_response_finalization.js | |
parent | d744c0c6d9a557bbaa2a23571ffb3acabf19c35a (diff) |
fix: close fetch response body on GC (#11467)
This commit fixes fetch response bodies to be automatically closed if
the `Response.body` readable stream goes out of scope and is GC'ed.
Diffstat (limited to 'cli/tests/fetch_response_finalization.js')
-rw-r--r-- | cli/tests/fetch_response_finalization.js | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/cli/tests/fetch_response_finalization.js b/cli/tests/fetch_response_finalization.js new file mode 100644 index 000000000..dd7c355eb --- /dev/null +++ b/cli/tests/fetch_response_finalization.js @@ -0,0 +1,16 @@ +async function doAFetch() { + const resp = await fetch("http://localhost:4545/README.md"); + console.log(Deno.resources()); // print the current resources + const _resp = resp; + // at this point resp can be GC'ed +} + +await doAFetch(); // create a resource + +globalThis.gc(); // force GC + +// It is very important that there is a yield here, otherwise the finalizer for +// the response body is not called and the resource is not closed. +await new Promise((resolve) => setTimeout(resolve, 0)); + +console.log(Deno.resources()); // print the current resources |