summaryrefslogtreecommitdiff
path: root/cli/permissions.rs
diff options
context:
space:
mode:
authorRyan Dahl <ry@tinyclouds.org>2020-08-10 17:31:05 -0400
committerGitHub <noreply@github.com>2020-08-10 17:31:05 -0400
commit7d01fcbb77169d446d58a5d8c1aa113a925092a0 (patch)
treefef5b3ab1e0d020b982a2692878039423ea6fcd3 /cli/permissions.rs
parent52c1017a74059655f9424f7ceb3f0c74dcc7f3be (diff)
Remove unnecessary drop calls (#7007)
Diffstat (limited to 'cli/permissions.rs')
-rw-r--r--cli/permissions.rs25
1 files changed, 8 insertions, 17 deletions
diff --git a/cli/permissions.rs b/cli/permissions.rs
index c89f8bcdb..d0ff31be5 100644
--- a/cli/permissions.rs
+++ b/cli/permissions.rs
@@ -710,7 +710,7 @@ mod tests {
#[test]
fn test_permissions_request_run() {
- let guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
+ let _guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
let mut perms0 = Permissions::from_flags(&Flags {
..Default::default()
});
@@ -722,12 +722,11 @@ mod tests {
});
set_prompt_result(false);
assert_eq!(perms1.request_run(), PermissionState::Deny);
- drop(guard);
}
#[test]
fn test_permissions_request_read() {
- let guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
+ let _guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
let allowlist = vec![PathBuf::from("/foo/bar")];
let mut perms0 = Permissions::from_flags(&Flags {
read_allowlist: allowlist.clone(),
@@ -760,12 +759,11 @@ mod tests {
perms2.request_read(&Some(Path::new("/foo/baz"))),
PermissionState::Deny
);
- drop(guard);
}
#[test]
fn test_permissions_request_write() {
- let guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
+ let _guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
let allowlist = vec![PathBuf::from("/foo/bar")];
let mut perms0 = Permissions::from_flags(&Flags {
write_allowlist: allowlist.clone(),
@@ -798,12 +796,11 @@ mod tests {
perms2.request_write(&Some(Path::new("/foo/baz"))),
PermissionState::Deny
);
- drop(guard);
}
#[test]
fn test_permission_request_net() {
- let guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
+ let _guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
let allowlist = svec!["localhost:8080"];
let mut perms0 = Permissions::from_flags(&Flags {
@@ -876,13 +873,11 @@ mod tests {
.kind_str,
"URIError"
);
-
- drop(guard);
}
#[test]
fn test_permissions_request_env() {
- let guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
+ let _guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
let mut perms0 = Permissions::from_flags(&Flags {
..Default::default()
});
@@ -894,12 +889,11 @@ mod tests {
});
set_prompt_result(false);
assert_eq!(perms1.request_env(), PermissionState::Deny);
- drop(guard);
}
#[test]
fn test_permissions_request_plugin() {
- let guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
+ let _guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
let mut perms0 = Permissions::from_flags(&Flags {
..Default::default()
});
@@ -911,12 +905,11 @@ mod tests {
});
set_prompt_result(false);
assert_eq!(perms1.request_plugin(), PermissionState::Deny);
- drop(guard);
}
#[test]
fn test_permissions_request_hrtime() {
- let guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
+ let _guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
let mut perms0 = Permissions::from_flags(&Flags {
..Default::default()
});
@@ -928,7 +921,6 @@ mod tests {
});
set_prompt_result(false);
assert_eq!(perms1.request_hrtime(), PermissionState::Deny);
- drop(guard);
}
#[test]
@@ -966,7 +958,7 @@ mod tests {
#[test]
fn test_fork() {
- let guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
+ let _guard = PERMISSION_PROMPT_GUARD.lock().unwrap();
let perms0 = Permissions::from_flags(&Flags {
..Default::default()
});
@@ -1028,6 +1020,5 @@ mod tests {
allow_hrtime: PermissionState::Deny,
}
);
- drop(guard);
}
}