summaryrefslogtreecommitdiff
path: root/cli/ops
diff options
context:
space:
mode:
authorDavid Sherret <dsherret@users.noreply.github.com>2024-05-08 22:45:06 -0400
committerGitHub <noreply@github.com>2024-05-08 22:45:06 -0400
commit47f7bed677a6b72e873712de8f3988ea891710e4 (patch)
tree096549459b479cf1383e65c87b77e9f9482df258 /cli/ops
parente6dc4dfbff25e77d2127591802229b4a74037d24 (diff)
chore: enable clippy::print_stdout and clippy::print_stderr (#23732)
1. Generally we should prefer to use the `log` crate. 2. I very often accidentally commit `eprintln`s. When we should use `println` or `eprintln`, it's not too bad to be a bit more verbose and ignore the lint rule.
Diffstat (limited to 'cli/ops')
-rw-r--r--cli/ops/jupyter.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/cli/ops/jupyter.rs b/cli/ops/jupyter.rs
index e7e206de5..1c60bc2bc 100644
--- a/cli/ops/jupyter.rs
+++ b/cli/ops/jupyter.rs
@@ -76,13 +76,13 @@ pub fn op_print(
if is_err {
if let Err(err) = sender.send(StdioMsg::Stderr(msg.into())) {
- eprintln!("Failed to send stderr message: {}", err);
+ log::error!("Failed to send stderr message: {}", err);
}
return Ok(());
}
if let Err(err) = sender.send(StdioMsg::Stdout(msg.into())) {
- eprintln!("Failed to send stdout message: {}", err);
+ log::error!("Failed to send stdout message: {}", err);
}
Ok(())
}