diff options
| author | Ryan Dahl <ry@tinyclouds.org> | 2020-02-03 18:08:44 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-02-03 18:08:44 -0500 |
| commit | 161cf7cdfd44ace8937fb7940727984990742d18 (patch) | |
| tree | 1ef88b3cd6427353366d930ea9be5ae494504255 /cli/ops/io.rs | |
| parent | 0471243334ac1aeb76dcaadbc3f0b8114d188fb8 (diff) | |
refactor: Use Tokio's single-threaded runtime (#3844)
This change simplifies how we execute V8. Previously V8 Isolates jumped
around threads every time they were woken up. This was overly complex and
potentially hurting performance in a myriad ways. Now isolates run on
their own dedicated thread and never move.
- blocking_json spawns a thread and does not use a thread pool
- op_host_poll_worker and op_host_resume_worker are non-operational
- removes Worker::get_message and Worker::post_message
- ThreadSafeState::workers table contains WorkerChannel entries instead
of actual Worker instances.
- MainWorker and CompilerWorker are no longer Futures.
- The multi-threaded version of deno_core_http_bench was removed.
- AyncOps no longer need to be Send + Sync
This PR is very large and several tests were disabled to speed
integration:
- installer_test_local_module_run
- installer_test_remote_module_run
- _015_duplicate_parallel_import
- _026_workers
Diffstat (limited to 'cli/ops/io.rs')
| -rw-r--r-- | cli/ops/io.rs | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/cli/ops/io.rs b/cli/ops/io.rs index 410748ca4..18ad3cf30 100644 --- a/cli/ops/io.rs +++ b/cli/ops/io.rs @@ -187,14 +187,14 @@ pub fn op_read( debug!("read rid={}", rid); let zero_copy = match zero_copy { None => { - return futures::future::err(deno_error::no_buffer_specified()).boxed() + return futures::future::err(deno_error::no_buffer_specified()) + .boxed_local() } Some(buf) => buf, }; let fut = read(state, rid as u32, zero_copy); - - fut.boxed() + fut.boxed_local() } /// `DenoAsyncWrite` is the same as the `tokio_io::AsyncWrite` trait @@ -332,12 +332,13 @@ pub fn op_write( debug!("write rid={}", rid); let zero_copy = match zero_copy { None => { - return futures::future::err(deno_error::no_buffer_specified()).boxed() + return futures::future::err(deno_error::no_buffer_specified()) + .boxed_local() } Some(buf) => buf, }; let fut = write(state, rid as u32, zero_copy); - fut.boxed() + fut.boxed_local() } |
