diff options
| author | Ryan Dahl <ry@tinyclouds.org> | 2020-02-03 18:08:44 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-02-03 18:08:44 -0500 |
| commit | 161cf7cdfd44ace8937fb7940727984990742d18 (patch) | |
| tree | 1ef88b3cd6427353366d930ea9be5ae494504255 /cli/ops/dispatch_minimal.rs | |
| parent | 0471243334ac1aeb76dcaadbc3f0b8114d188fb8 (diff) | |
refactor: Use Tokio's single-threaded runtime (#3844)
This change simplifies how we execute V8. Previously V8 Isolates jumped
around threads every time they were woken up. This was overly complex and
potentially hurting performance in a myriad ways. Now isolates run on
their own dedicated thread and never move.
- blocking_json spawns a thread and does not use a thread pool
- op_host_poll_worker and op_host_resume_worker are non-operational
- removes Worker::get_message and Worker::post_message
- ThreadSafeState::workers table contains WorkerChannel entries instead
of actual Worker instances.
- MainWorker and CompilerWorker are no longer Futures.
- The multi-threaded version of deno_core_http_bench was removed.
- AyncOps no longer need to be Send + Sync
This PR is very large and several tests were disabled to speed
integration:
- installer_test_local_module_run
- installer_test_remote_module_run
- _015_duplicate_parallel_import
- _026_workers
Diffstat (limited to 'cli/ops/dispatch_minimal.rs')
| -rw-r--r-- | cli/ops/dispatch_minimal.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cli/ops/dispatch_minimal.rs b/cli/ops/dispatch_minimal.rs index b9a4f7530..70c4af6c3 100644 --- a/cli/ops/dispatch_minimal.rs +++ b/cli/ops/dispatch_minimal.rs @@ -16,7 +16,7 @@ use futures::future::FutureExt; use std::future::Future; use std::pin::Pin; -pub type MinimalOp = dyn Future<Output = Result<i32, ErrBox>> + Send; +pub type MinimalOp = dyn Future<Output = Result<i32, ErrBox>>; #[derive(Copy, Clone, Debug, PartialEq)] // This corresponds to RecordMinimal on the TS side. @@ -164,7 +164,7 @@ where // works since they're simple polling futures. Op::Sync(futures::executor::block_on(fut).unwrap()) } else { - Op::Async(fut.boxed()) + Op::Async(fut.boxed_local()) } } } |
