diff options
author | David Sherret <dsherret@users.noreply.github.com> | 2023-02-22 22:45:35 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-02-22 22:45:35 -0500 |
commit | b15f9e60a040e2e450e7ca9971a5fc07dbf8b94c (patch) | |
tree | 4290744b0c0a8f8f5d063322a650fdabf2d3150c /cli/npm/resolvers/mod.rs | |
parent | cc8e4a00aaf4c4fe959944c7400f2e259f7faae8 (diff) |
feat(task): support scripts in package.json (#17887)
This is a super basic initial implementation. We don't create a
`node_modules/.bin` folder at the moment and add it to the PATH like we
should which is necessary to make command name resolution in the
subprocess work properly (ex. you run a script that launches another
script that then tries to launch an "npx command"... this won't work
atm).
Closes #17492
Diffstat (limited to 'cli/npm/resolvers/mod.rs')
-rw-r--r-- | cli/npm/resolvers/mod.rs | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/cli/npm/resolvers/mod.rs b/cli/npm/resolvers/mod.rs index 2450638bf..039864c5f 100644 --- a/cli/npm/resolvers/mod.rs +++ b/cli/npm/resolvers/mod.rs @@ -150,25 +150,23 @@ impl NpmPackageResolver { /// Resolves an npm package folder path from a Deno module. pub fn resolve_package_folder_from_deno_module( &self, - package_id: &NpmPackageNv, + pkg_nv: &NpmPackageNv, ) -> Result<PathBuf, AnyError> { - let node_id = self - .resolution - .resolve_pkg_id_from_deno_module(package_id)?; - self.resolve_pkg_folder_from_deno_module_at_node_id(&node_id) + let pkg_id = self.resolution.resolve_pkg_id_from_deno_module(pkg_nv)?; + self.resolve_pkg_folder_from_deno_module_at_pkg_id(&pkg_id) } - fn resolve_pkg_folder_from_deno_module_at_node_id( + fn resolve_pkg_folder_from_deno_module_at_pkg_id( &self, - package_id: &NpmPackageId, + pkg_id: &NpmPackageId, ) -> Result<PathBuf, AnyError> { let path = self .fs_resolver - .resolve_package_folder_from_deno_module(package_id)?; + .resolve_package_folder_from_deno_module(pkg_id)?; let path = canonicalize_path_maybe_not_exists(&path)?; log::debug!( "Resolved package folder of {} to {}", - package_id.as_serialized(), + pkg_id.as_serialized(), path.display() ); Ok(path) |