diff options
author | David Sherret <dsherret@users.noreply.github.com> | 2023-02-24 19:35:43 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-02-24 19:35:43 -0500 |
commit | 033b70af19300a4e34dcf19ab0031245bfc19625 (patch) | |
tree | ebcd8e9ebd85a974c9845af0291ab3bdb9765704 /cli/npm/resolvers/mod.rs | |
parent | 5683daf1aa1c01f5f4d01879d6ce054b0922faf6 (diff) |
fix(npm): lazily install package.json dependencies only when necessary (#17931)
This lazily does an "npm install" when any package name matches what's
found in the package.json or when running a script from package.json
with deno task.
Part of #17916
Closes #17928
Diffstat (limited to 'cli/npm/resolvers/mod.rs')
-rw-r--r-- | cli/npm/resolvers/mod.rs | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/cli/npm/resolvers/mod.rs b/cli/npm/resolvers/mod.rs index f68eeac26..0027698c0 100644 --- a/cli/npm/resolvers/mod.rs +++ b/cli/npm/resolvers/mod.rs @@ -19,7 +19,6 @@ use deno_runtime::deno_node::RequireNpmResolver; use global::GlobalNpmPackageResolver; use serde::Deserialize; use serde::Serialize; -use std::collections::BTreeMap; use std::path::Path; use std::path::PathBuf; use std::sync::Arc; @@ -224,19 +223,6 @@ impl NpmPackageResolver { self.resolution.has_packages() } - /// Adds the package reqs from a package.json if they exist. - pub async fn add_package_json_deps( - &self, - maybe_package_json_deps: Option<&BTreeMap<String, NpmPackageReq>>, - ) -> Result<(), AnyError> { - if let Some(deps) = maybe_package_json_deps { - let mut package_reqs = deps.values().cloned().collect::<Vec<_>>(); - package_reqs.sort(); // deterministic resolution - self.add_package_reqs(package_reqs).await?; - } - Ok(()) - } - /// Adds package requirements to the resolver and ensures everything is setup. pub async fn add_package_reqs( &self, |