perf(lsp): concurrent reads and exclusive writes (#17135)

1 files changed, 7 insertions, 10 deletions

diff --git a/cli/npm/resolvers/global.rs b/cli/npm/resolvers/global.rs
index 093e15ded..b005cbaeb 100644
--- a/cli/npm/resolvers/global.rs
+++ b/cli/npm/resolvers/global.rs
@@ -138,11 +138,7 @@ impl InnerNpmPackageResolver for GlobalNpmPackageResolver {
     packages: Vec<NpmPackageReq>,
   ) -> BoxFuture<'static, Result<(), AnyError>> {
     let resolver = self.clone();
-    async move {
-      resolver.resolution.add_package_reqs(packages).await?;
-      cache_packages_in_resolver(&resolver).await
-    }
-    .boxed()
+    async move { resolver.resolution.add_package_reqs(packages).await }.boxed()
   }
 
   fn set_package_reqs(
@@ -150,11 +146,12 @@ impl InnerNpmPackageResolver for GlobalNpmPackageResolver {
     packages: HashSet<NpmPackageReq>,
   ) -> BoxFuture<'static, Result<(), AnyError>> {
     let resolver = self.clone();
-    async move {
-      resolver.resolution.set_package_reqs(packages).await?;
-      cache_packages_in_resolver(&resolver).await
-    }
-    .boxed()
+    async move { resolver.resolution.set_package_reqs(packages).await }.boxed()
+  }
+
+  fn cache_packages(&self) -> BoxFuture<'static, Result<(), AnyError>> {
+    let resolver = self.clone();
+    async move { cache_packages_in_resolver(&resolver).await }.boxed()
   }
 
   fn ensure_read_permission(&self, path: &Path) -> Result<(), AnyError> {