diff options
| author | Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> | 2024-07-19 11:59:04 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-07-19 18:59:04 +0000 |
| commit | a4c76add565b9674ef6880de88013948c61a1ce5 (patch) | |
| tree | 6dc75f90b2788b1028453308f3b46708d460936f /cli/npm/managed | |
| parent | f6c7c13764a7952b878a2141fdf01ed68d169ea2 (diff) | |
fix(cli): Respect implied BYONM from DENO_FUTURE in `deno task` (#24652)
Regression from
https://github.com/denoland/deno/commit/04f9db5b2217fe06f88e76146aac6362ff0b0b86
Originally I thought to fix the issue in the PR we needed to explicitly
pass through the `node-modules-dir` flag, but after applying the correct
fix that david pointed out (setting `NPM_PROCESS_STATE`) that wasn't
necessary (or correct).
We had a test for deno task with BYONM, but it only tested with
`"unstable": ["byonm"]` in deno.json, so it didn't catch this.
Diffstat (limited to 'cli/npm/managed')
| -rw-r--r-- | cli/npm/managed/resolvers/local.rs | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/cli/npm/managed/resolvers/local.rs b/cli/npm/managed/resolvers/local.rs index 2240bf0c0..90a17b157 100644 --- a/cli/npm/managed/resolvers/local.rs +++ b/cli/npm/managed/resolvers/local.rs @@ -282,12 +282,8 @@ fn resolve_baseline_custom_commands( custom_commands .insert("npm".to_string(), Rc::new(crate::task_runner::NpmCommand)); - custom_commands.insert( - "node".to_string(), - Rc::new(crate::task_runner::NodeCommand { - force_node_modules_dir: true, - }), - ); + custom_commands + .insert("node".to_string(), Rc::new(crate::task_runner::NodeCommand)); custom_commands.insert( "node-gyp".to_string(), |