diff options
| author | Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> | 2024-09-24 12:23:57 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-24 19:23:57 +0000 |
| commit | 36ebc03f177cc7db5deb93f4d403cafbed756eb5 (patch) | |
| tree | c36af6c9b7093d3191de3cd6e60c4ce9dca4151a /cli/npm/managed/resolvers/common.rs | |
| parent | ba5b8d0213cde2585236098b00beb8a512889626 (diff) | |
fix(cli): Warn on not-run lifecycle scripts with global cache (#25786)
Refactors the lifecycle scripts code to extract out the common
functionality and then uses that to provide a warning in the global
resolver.
While ideally we would still support them with the global cache, for now
a warning is at least better than the status quo (where people are
unaware why their packages aren't working).
Diffstat (limited to 'cli/npm/managed/resolvers/common.rs')
| -rw-r--r-- | cli/npm/managed/resolvers/common.rs | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/cli/npm/managed/resolvers/common.rs b/cli/npm/managed/resolvers/common.rs index 1893aa56a..620daf4b3 100644 --- a/cli/npm/managed/resolvers/common.rs +++ b/cli/npm/managed/resolvers/common.rs @@ -1,5 +1,8 @@ // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. +pub mod bin_entries; +pub mod lifecycle_scripts; + use std::collections::HashMap; use std::io::ErrorKind; use std::path::Path; @@ -134,7 +137,7 @@ impl RegistryReadPermissionChecker { /// Caches all the packages in parallel. pub async fn cache_packages( - packages: Vec<NpmResolutionPackage>, + packages: &[NpmResolutionPackage], tarball_cache: &Arc<TarballCache>, ) -> Result<(), AnyError> { let mut futures_unordered = futures::stream::FuturesUnordered::new(); |