chore: rename some helpers on the Fs trait (#20097)

Rename some of the helper methods on the Fs trait to be suffixed with
`_sync` / `_async`, in preparation of the introduction of more async
methods for some helpers.

Also adds a `read_text_file_async` helper to complement the renamed
`read_text_file_sync` helper.

1 files changed, 5 insertions, 3 deletions

diff --git a/cli/node.rs b/cli/node.rs
index 2a9a84ef9..158627202 100644
--- a/cli/node.rs
+++ b/cli/node.rs
@@ -91,9 +91,11 @@ impl CjsCodeAnalyzer for CliCjsCodeAnalyzer {
   ) -> Result<ExtNodeCjsAnalysis, AnyError> {
     let source = match source {
       Some(source) => Cow::Borrowed(source),
-      None => {
-        Cow::Owned(self.fs.read_to_string(&specifier.to_file_path().unwrap())?)
-      }
+      None => Cow::Owned(
+        self
+          .fs
+          .read_text_file_sync(&specifier.to_file_path().unwrap())?,
+      ),
     };
     let analysis = self.inner_cjs_analysis(specifier, &source)?;
     Ok(ExtNodeCjsAnalysis {