diff options
| author | Luke Channings <461449+LukeChannings@users.noreply.github.com> | 2022-10-15 16:21:04 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-15 20:51:04 +0530 |
| commit | fa22956a8616c34482b10bb3ae1aed76ad017c3e (patch) | |
| tree | 72faa8304d74bf8ec910e8bfcd9af7cf80a5cca2 /cli/napi/mod.rs | |
| parent | e32719c2915aee9055327609ef03cf9bfc2b1785 (diff) | |
refactor(build): better handle old glibc (#16238)
Follow-up to #16208.
- Refactors build.rs behaviour to use `-exported_symbols_list` /
`--export-dynamic-symbol-list`
- Since all build systems now rely on a symbols list file, I have added
`generate_exported_symbols_list`, which derives the symbol list file
depending on the platform, which makes `tools/napi/generate_link_win.js`
redundant.
- Fixes a missed instance of `i8` being used instead of `c_char`
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
Diffstat (limited to 'cli/napi/mod.rs')
| -rw-r--r-- | cli/napi/mod.rs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cli/napi/mod.rs b/cli/napi/mod.rs index 8982a732a..1712632a5 100644 --- a/cli/napi/mod.rs +++ b/cli/napi/mod.rs @@ -7,13 +7,13 @@ //! Symbols to be exported are now defined in this JSON file. //! The `#[napi_sym]` macro checks for missing entries and panics. //! -//! `./tools/napi/generate_link_win.js` is used to generate the LINK `cli/exports.def` on Windows, +//! `./tools/napi/generate_symbols_list.js` is used to generate the LINK `cli/exports.def` on Windows, //! which is also checked into git. //! //! To add a new napi function: //! 1. Place `#[napi_sym]` on top of your implementation. //! 2. Add the function's identifier to this JSON list. -//! 3. Finally, run `./tools/napi/generate_link_win.js` to update `cli/exports.def`. +//! 3. Finally, run `./tools/napi/generate_symbols_list.js` to update `cli/generated_symbol_exports_list_*.def`. pub mod r#async; pub mod env; |