diff options
author | Divy Srivastava <dj.srivastava23@gmail.com> | 2023-01-23 05:30:01 -0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-01-23 19:00:01 +0530 |
commit | cd192313064bc2e9d65e3e734930cfaf15f4191b (patch) | |
tree | b8187cfe80025efa6e7e1c1960a6bf9349e2a31f /cli/napi/js_native_api.rs | |
parent | c3e0b12c72673badece8ef5d789a942637d893ba (diff) |
fix(napi): improve napi_adjust_external_memory (#17501)
<!--
Before submitting a PR, please read http://deno.land/manual/contributing
1. Give the PR a descriptive title.
Examples of good title:
- fix(std/http): Fix race condition in server
- docs(console): Update docstrings
- feat(doc): Handle nested reexports
Examples of bad title:
- fix #7123
- update docs
- fix bugs
2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't
run
all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench'
label.
-->
Diffstat (limited to 'cli/napi/js_native_api.rs')
-rw-r--r-- | cli/napi/js_native_api.rs | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/cli/napi/js_native_api.rs b/cli/napi/js_native_api.rs index 05e07b1e5..62ac40159 100644 --- a/cli/napi/js_native_api.rs +++ b/cli/napi/js_native_api.rs @@ -1223,13 +1223,17 @@ fn napi_add_finalizer( fn napi_adjust_external_memory( env: *mut Env, change_in_bytes: i64, - adjusted_value: &mut i64, + adjusted_value: *mut i64, ) -> Result { check_env!(env); + check_arg!(env, adjusted_value); + let env = unsafe { &mut *env }; let isolate = &mut *env.isolate_ptr; *adjusted_value = isolate.adjust_amount_of_external_allocated_memory(change_in_bytes); + + napi_clear_last_error(env); Ok(()) } |