diff options
| author | Divy Srivastava <dj.srivastava23@gmail.com> | 2023-01-14 05:02:42 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-14 13:02:42 +0000 |
| commit | b9cd19a1e842a3807a5284a079dd7daf78245489 (patch) | |
| tree | a7cd05fc7904a5740602c31019ef200099a56e2d /cli/napi/env.rs | |
| parent | b4ce48c80ab0b2f4c0d32b03b8f49becba8d5416 (diff) | |
chore(napi): Remove unstable libuv methods (#17416)
This commit removes the libuv pollyfills introduced with Node-API
support.
It is too much Node-specific. Most Node-API modules that depend on libuv
are already giving up the benefits of Node-API. We should rather
encourage modules to use `ThreadSafeFunction` or `AsyncWork` to
interface with the event loop.
Relevant discussion a few months ago:
https://github.com/denoland/deno/pull/13633#discussion_r904916178
cc @bartlomieju
Diffstat (limited to 'cli/napi/env.rs')
| -rw-r--r-- | cli/napi/env.rs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/cli/napi/env.rs b/cli/napi/env.rs index 841b6cd96..558b9b012 100644 --- a/cli/napi/env.rs +++ b/cli/napi/env.rs @@ -141,8 +141,7 @@ fn napi_module_register(module: *const NapiModule) -> Result { #[napi_sym::napi_sym] fn napi_get_uv_event_loop(_env: *mut Env, uv_loop: *mut *mut ()) -> Result { - // Don't error out because addons may pass this to - // our libuv _polyfills_. + // There is no uv_loop in Deno *uv_loop = std::ptr::null_mut(); Ok(()) } |