diff options
| author | Luke Channings <461449+LukeChannings@users.noreply.github.com> | 2022-10-15 16:21:04 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-15 20:51:04 +0530 |
| commit | fa22956a8616c34482b10bb3ae1aed76ad017c3e (patch) | |
| tree | 72faa8304d74bf8ec910e8bfcd9af7cf80a5cca2 /cli/napi/README.md | |
| parent | e32719c2915aee9055327609ef03cf9bfc2b1785 (diff) | |
refactor(build): better handle old glibc (#16238)
Follow-up to #16208.
- Refactors build.rs behaviour to use `-exported_symbols_list` /
`--export-dynamic-symbol-list`
- Since all build systems now rely on a symbols list file, I have added
`generate_exported_symbols_list`, which derives the symbol list file
depending on the platform, which makes `tools/napi/generate_link_win.js`
redundant.
- Fixes a missed instance of `i8` being used instead of `c_char`
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
Diffstat (limited to 'cli/napi/README.md')
| -rw-r--r-- | cli/napi/README.md | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/cli/napi/README.md b/cli/napi/README.md index 7f46d9797..210d89b18 100644 --- a/cli/napi/README.md +++ b/cli/napi/README.md @@ -44,10 +44,10 @@ pub fn napi_get_boolean( } ``` -Update the Windows `.def` file using the script: +Update the generated symbol lists using the script: ``` -deno run --allow-write tools/napi/generate_link_win.js +deno run --allow-write tools/napi/generate_symbols_lists.js ``` Add a test in [`/test_napi`](../../test_napi/). You can also refer to Node.js @@ -109,7 +109,7 @@ unsafe extern "C" fn napi_register_module_v1( ) -> napi_value { ... + boolean::init(env, exports); - + exports } ``` |