diff options
| author | Bartek Iwańczuk <biwanczuk@gmail.com> | 2023-02-15 19:44:52 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-15 19:44:52 +0100 |
| commit | 75209e12f19ca5d4a2a7c9008fba63a487ad8e6a (patch) | |
| tree | c122feabbceeef070de4d4eb23667c6153ea7eb1 /cli/module_loader.rs | |
| parent | c4b9a91e27a32c0949688034c2449936c01a44a9 (diff) | |
feat: wire up ext/node to the Node compatibility layer (#17785)
This PR changes Node.js/npm compatibility layer to use polyfills for
built-in Node.js
embedded in the snapshot (that are coming from "ext/node" extension).
As a result loading `std/node`, either from
"https://deno.land/std@<latest>/" or
from "DENO_NODE_COMPAT_URL" env variable were removed. All code that is
imported via "npm:" specifiers now uses code embedded in the snapshot.
Several fixes were applied to various modules in "ext/node" to make
tests pass.
---------
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
Diffstat (limited to 'cli/module_loader.rs')
| -rw-r--r-- | cli/module_loader.rs | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/cli/module_loader.rs b/cli/module_loader.rs index b61b4304e..462b41cbb 100644 --- a/cli/module_loader.rs +++ b/cli/module_loader.rs @@ -77,11 +77,10 @@ impl CliModuleLoader { specifier: &ModuleSpecifier, maybe_referrer: Option<ModuleSpecifier>, ) -> Result<ModuleCodeSource, AnyError> { - // TODO(bartlomieju): uncomment, when all `node:` module have been - // snapshotted - // if specifier.scheme() == "node" { - // unreachable!("Node built-in modules should be handled internally."); - // } + if specifier.scheme() == "node" { + unreachable!("Node built-in modules should be handled internally."); + } + let graph = self.ps.graph(); match graph.get(specifier) { Some(deno_graph::Module { |