diff options
| author | Nayeem Rahman <nayeemrmn99@gmail.com> | 2023-04-26 21:23:28 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-26 16:23:28 -0400 |
| commit | 3d8a4d3b81e107bbb152ad69047f64d16ca800f3 (patch) | |
| tree | 52c8d5e655e3b4bc51aabee1bbfe428a3b7b394a /cli/module_loader.rs | |
| parent | c2f5c096925e2fc303f6ea1c36cdba38748c9217 (diff) | |
feat(cli): don't check permissions for statically analyzable dynamic imports (#18713)
Closes #17697
Closes #17658
Diffstat (limited to 'cli/module_loader.rs')
| -rw-r--r-- | cli/module_loader.rs | 17 |
1 files changed, 3 insertions, 14 deletions
diff --git a/cli/module_loader.rs b/cli/module_loader.rs index 979898374..e4b8b616d 100644 --- a/cli/module_loader.rs +++ b/cli/module_loader.rs @@ -109,15 +109,12 @@ impl ModuleLoadPreparer { roots: Vec<ModuleSpecifier>, is_dynamic: bool, lib: TsTypeLib, - root_permissions: PermissionsContainer, - dynamic_permissions: PermissionsContainer, + permissions: PermissionsContainer, ) -> Result<(), AnyError> { log::debug!("Preparing module load."); let _pb_clear_guard = self.progress_bar.clear_guard(); - let mut cache = self - .module_graph_builder - .create_fetch_cacher(root_permissions, dynamic_permissions); + let mut cache = self.module_graph_builder.create_fetch_cacher(permissions); let maybe_imports = self.options.to_maybe_imports()?; let graph_resolver = self.resolver.as_graph_resolver(); let graph_npm_resolver = self.resolver.as_graph_npm_resolver(); @@ -216,7 +213,6 @@ impl ModuleLoadPreparer { false, lib, PermissionsContainer::allow_all(), - PermissionsContainer::allow_all(), ) .await } @@ -537,7 +533,6 @@ impl ModuleLoader for CliModuleLoader { let specifier = specifier.clone(); let module_load_preparer = self.module_load_preparer.clone(); - let dynamic_permissions = self.dynamic_permissions.clone(); let root_permissions = if is_dynamic { self.dynamic_permissions.clone() } else { @@ -547,13 +542,7 @@ impl ModuleLoader for CliModuleLoader { async move { module_load_preparer - .prepare_module_load( - vec![specifier], - is_dynamic, - lib, - root_permissions, - dynamic_permissions, - ) + .prepare_module_load(vec![specifier], is_dynamic, lib, root_permissions) .await } .boxed_local() |