summaryrefslogtreecommitdiff
path: root/cli/metrics.rs
diff options
context:
space:
mode:
authorRyan Dahl <ry@tinyclouds.org>2020-09-10 09:57:45 -0400
committerGitHub <noreply@github.com>2020-09-10 09:57:45 -0400
commit7c2e7c660804afca823d60e6496aa853f75db16c (patch)
treeb7746b181c1564c6b1abd2e906662f9e6b008417 /cli/metrics.rs
parent6f70e6e72ba2d5c1de7495adac37c1e4f4e86b24 (diff)
Use gotham-like state for ops (#7385)
Provides a concrete state type that can be dynamically added. This is necessary for op crates. * renames BasicState to OpState * async ops take `Rc<RefCell<OpState>>` * sync ops take `&mut OpState` * removes `OpRegistry`, `OpRouter` traits * `get_error_class_fn` moved to OpState * ResourceTable moved to OpState
Diffstat (limited to 'cli/metrics.rs')
-rw-r--r--cli/metrics.rs57
1 files changed, 57 insertions, 0 deletions
diff --git a/cli/metrics.rs b/cli/metrics.rs
index 43f11cd36..227c10f60 100644
--- a/cli/metrics.rs
+++ b/cli/metrics.rs
@@ -71,3 +71,60 @@ impl Metrics {
self.op_completed(bytes_received);
}
}
+
+use deno_core::BufVec;
+use deno_core::Op;
+use deno_core::OpFn;
+use deno_core::OpState;
+use std::cell::RefCell;
+use std::rc::Rc;
+
+pub fn metrics_op(op_fn: Box<OpFn>) -> Box<OpFn> {
+ Box::new(move |op_state: Rc<RefCell<OpState>>, bufs: BufVec| -> Op {
+ // TODOs:
+ // * The 'bytes' metrics seem pretty useless, especially now that the
+ // distinction between 'control' and 'data' buffers has become blurry.
+ // * Tracking completion of async ops currently makes us put the boxed
+ // future into _another_ box. Keeping some counters may not be expensive
+ // in itself, but adding a heap allocation for every metric seems bad.
+ let mut buf_len_iter = bufs.iter().map(|buf| buf.len());
+ let bytes_sent_control = buf_len_iter.next().unwrap_or(0);
+ let bytes_sent_data = buf_len_iter.sum();
+
+ let op = (op_fn)(op_state.clone(), bufs);
+
+ let cli_state = crate::ops::cli_state2(&op_state);
+ let cli_state_ = cli_state.clone();
+ let mut metrics = cli_state.metrics.borrow_mut();
+
+ use futures::future::FutureExt;
+
+ match op {
+ Op::Sync(buf) => {
+ metrics.op_sync(bytes_sent_control, bytes_sent_data, buf.len());
+ Op::Sync(buf)
+ }
+ Op::Async(fut) => {
+ metrics.op_dispatched_async(bytes_sent_control, bytes_sent_data);
+ let fut = fut
+ .inspect(move |buf| {
+ let mut metrics = cli_state_.metrics.borrow_mut();
+ metrics.op_completed_async(buf.len());
+ })
+ .boxed_local();
+ Op::Async(fut)
+ }
+ Op::AsyncUnref(fut) => {
+ metrics.op_dispatched_async_unref(bytes_sent_control, bytes_sent_data);
+ let fut = fut
+ .inspect(move |buf| {
+ let mut metrics = cli_state_.metrics.borrow_mut();
+ metrics.op_completed_async_unref(buf.len());
+ })
+ .boxed_local();
+ Op::AsyncUnref(fut)
+ }
+ other => other,
+ }
+ })
+}