summaryrefslogtreecommitdiff
path: root/cli/mainrt.rs
diff options
context:
space:
mode:
authorsnek <snek@deno.com>2024-11-14 13:16:28 +0100
committerGitHub <noreply@github.com>2024-11-14 12:16:28 +0000
commit4e899d48cffa95617266dd8f9aef54603a87ad82 (patch)
treeec667f58ccb4126ecad38bc4600d9dd8dc372ca5 /cli/mainrt.rs
parentcb107a762fb903973e0d0c2e4481baf2c0bc13b8 (diff)
fix: otel resiliency (#26857)
Improving the breadth of collected data, and ensuring that the collected data is more likely to be successfully reported. - Use `log` crate in more places - Hook up `log` crate to otel - Switch to process-wide otel processors - Handle places that use `process::exit` Also adds a more robust testing framework, with a deterministic tracing setting. Refs: https://github.com/denoland/deno/issues/26852
Diffstat (limited to 'cli/mainrt.rs')
-rw-r--r--cli/mainrt.rs20
1 files changed, 12 insertions, 8 deletions
diff --git a/cli/mainrt.rs b/cli/mainrt.rs
index f5b798f81..2951aa711 100644
--- a/cli/mainrt.rs
+++ b/cli/mainrt.rs
@@ -40,23 +40,21 @@ use std::env::current_exe;
use crate::args::Flags;
-#[allow(clippy::print_stderr)]
pub(crate) fn unstable_exit_cb(feature: &str, api_name: &str) {
- eprintln!(
+ log::error!(
"Unstable API '{api_name}'. The `--unstable-{}` flag must be provided.",
feature
);
- std::process::exit(70);
+ deno_runtime::exit(70);
}
-#[allow(clippy::print_stderr)]
fn exit_with_message(message: &str, code: i32) -> ! {
- eprintln!(
+ log::error!(
"{}: {}",
colors::red_bold("error"),
message.trim_start_matches("error: ")
);
- std::process::exit(code);
+ deno_runtime::exit(code);
}
fn unwrap_or_exit<T>(result: Result<T, AnyError>) -> T {
@@ -89,13 +87,19 @@ fn main() {
let future = async move {
match standalone {
Ok(Some(data)) => {
+ if let Some(otel_config) = data.metadata.otel_config.clone() {
+ deno_runtime::ops::otel::init(otel_config)?;
+ }
util::logger::init(data.metadata.log_level);
load_env_vars(&data.metadata.env_vars_from_env_file);
let exit_code = standalone::run(data).await?;
- std::process::exit(exit_code);
+ deno_runtime::exit(exit_code);
}
Ok(None) => Ok(()),
- Err(err) => Err(err),
+ Err(err) => {
+ util::logger::init(None);
+ Err(err)
+ }
}
};