core: snapshot improvements (#2052)

* Moves how snapshots are supplied to the Isolate. Previously they were
  given by Behavior::startup_data() but it was only called once at
  startup. It makes more sense (and simplifies Behavior) to pass it to the
  constructor of Isolate.
* Adds new libdeno type deno_snapshot instead of overloading
  deno_buf.
* Adds new libdeno method to delete snapshot deno_snapshot_delete().
* Renames deno_get_snapshot() to deno_snapshot_new().
* Makes StartupData hold references to snapshots. This was implicit when
  it previously held a deno_buf but is made explicit now. Note that
  include_bytes!() returns a &'static [u8] and we want to avoid
  copying that.

1 files changed, 2 insertions, 3 deletions

diff --git a/cli/main.rs b/cli/main.rs
index 4d0ceab5a..bda4f7b8f 100644
--- a/cli/main.rs
+++ b/cli/main.rs
@@ -107,9 +107,8 @@ fn main() {
 
   let state = Arc::new(IsolateState::new(flags, rest_argv, None, false));
   let state_ = state.clone();
-  let startup_data = startup_data::deno_isolate_init();
-  let cli = CliBehavior::new(Some(startup_data), state_);
-  let mut isolate = Isolate::new(cli);
+  let cli = CliBehavior::new(state_);
+  let mut isolate = Isolate::new(startup_data::deno_isolate_init(), cli);
 
   let main_future = lazy(move || {
     // Setup runtime.