diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-09-04 17:39:30 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-04 17:39:30 +0200 |
| commit | 07ad47da53d1fbabf6fc5d26c89dc6ba683d27fd (patch) | |
| tree | 9b59f66129ec8a9b6bb1737e8733fd2d352c1f98 /cli/lsp | |
| parent | 5400f1af6cdca6a71de80093c9d49cdde1f34ce5 (diff) | |
BREAKING(config): make supported compilerOptions an allow list (#25432)
Deno has been using a deny list, which doesn't make sense because a lot
of these options don't even work.
Closes #25363
Diffstat (limited to 'cli/lsp')
| -rw-r--r-- | cli/lsp/config.rs | 8 | ||||
| -rw-r--r-- | cli/lsp/language_server.rs | 5 |
2 files changed, 5 insertions, 8 deletions
diff --git a/cli/lsp/config.rs b/cli/lsp/config.rs index f9262d12e..fcea96aa5 100644 --- a/cli/lsp/config.rs +++ b/cli/lsp/config.rs @@ -1387,10 +1387,8 @@ impl ConfigData { } } - let node_modules_dir = member_dir - .workspace - .node_modules_dir_mode() - .unwrap_or_default(); + let node_modules_dir = + member_dir.workspace.node_modules_dir().unwrap_or_default(); let byonm = match node_modules_dir { Some(mode) => mode == NodeModulesDirMode::Manual, None => member_dir.workspace.root_pkg_json().is_some(), @@ -1873,7 +1871,7 @@ fn resolve_node_modules_dir( // `nodeModulesDir: true` setting in the deno.json file. This is to // reduce the chance of modifying someone's node_modules directory // without them having asked us to do so. - let node_modules_mode = workspace.node_modules_dir_mode().ok().flatten(); + let node_modules_mode = workspace.node_modules_dir().ok().flatten(); let explicitly_disabled = node_modules_mode == Some(NodeModulesDirMode::None); if explicitly_disabled { return None; diff --git a/cli/lsp/language_server.rs b/cli/lsp/language_server.rs index 05c54dfc6..2bb13e5e4 100644 --- a/cli/lsp/language_server.rs +++ b/cli/lsp/language_server.rs @@ -966,9 +966,8 @@ impl Inner { .await; for config_file in self.config.tree.config_files() { (|| { - let compiler_options = config_file.to_compiler_options().ok()?.0; - let compiler_options_obj = compiler_options.as_object()?; - let jsx_import_source = compiler_options_obj.get("jsxImportSource")?; + let compiler_options = config_file.to_compiler_options().ok()?.options; + let jsx_import_source = compiler_options.get("jsxImportSource")?; let jsx_import_source = jsx_import_source.as_str()?; let referrer = config_file.specifier.clone(); let specifier = Url::parse(&format!( |