diff options
author | Bartek IwaĆczuk <biwanczuk@gmail.com> | 2022-12-30 14:11:50 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-12-30 14:11:50 +0100 |
commit | 98bbf87742969802b392130c536454aa61a20395 (patch) | |
tree | 09a66a1daeadc9ee2706e2225a82fae96776f64f /cli/lsp/tsc.rs | |
parent | 218d7ab7780d5e44d3badd1102a65a1be2afd00a (diff) |
fix(lsp): less agressive completion triggers (#17225)
Closes https://github.com/denoland/deno/issues/17056
Closes https://github.com/denoland/deno/issues/17055
Diffstat (limited to 'cli/lsp/tsc.rs')
-rw-r--r-- | cli/lsp/tsc.rs | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/cli/lsp/tsc.rs b/cli/lsp/tsc.rs index 7145d00c2..8a83839bf 100644 --- a/cli/lsp/tsc.rs +++ b/cli/lsp/tsc.rs @@ -2007,6 +2007,10 @@ impl CompletionEntryDetails { documentation, command, additional_text_edits, + // NOTE(bartlomieju): it's not entirely clear to me why we need to do that, + // but when `completionItem/resolve` is called, we get a list of commit chars + // even though we might have returned an empty list in `completion` request. + commit_characters: None, ..original_item.clone() }) } |