summaryrefslogtreecommitdiff
path: root/cli/lsp/testing
diff options
context:
space:
mode:
authorMatt Mastracci <matthew@mastracci.com>2024-02-28 15:12:21 -0700
committerGitHub <noreply@github.com>2024-02-28 22:12:21 +0000
commitb6e44f91ad55f9737d65a4832d10cfa608f27c41 (patch)
treee184d9c7b0a4ebbb7cbb20ab72cc99c07eb46da0 /cli/lsp/testing
parentc9b2139b1e7e1240db792173118b7d54d16c5f73 (diff)
fix(cli): ensure that pre- and post-test output is flushed at the appropriate times (#22611)
Some `deno_std` tests were failing to print output that was resolved after the last test finished. In addition, output printed before tests began would sometimes appear above the "running X tests ..." line, and sometimes below it depending on timing. We now guarantee that all output is flushed before and after tests run, making the output consistent. Pre-test and post-test output are captured in `------ pre-test output ------` and `------ post-test output ------` blocks to differentiate them from the regular output blocks. Here's an example of a test (that is much noisier than normal, but an example of what the output will look like): ``` Check ./load_unload.ts ------- pre-test output ------- load ----- output end ----- running 1 test from ./load_unload.ts test ... ------- output ------- test ----- output end ----- test ... ok ([WILDCARD]) ------- post-test output ------- unload ----- output end ----- ```
Diffstat (limited to 'cli/lsp/testing')
-rw-r--r--cli/lsp/testing/execution.rs7
1 files changed, 7 insertions, 0 deletions
diff --git a/cli/lsp/testing/execution.rs b/cli/lsp/testing/execution.rs
index 78ee6c7f8..3c7921c88 100644
--- a/cli/lsp/testing/execution.rs
+++ b/cli/lsp/testing/execution.rs
@@ -397,6 +397,9 @@ impl TestRun {
);
}
}
+ test::TestEvent::Completed => {
+ reporter.report_completed();
+ }
test::TestEvent::ForceEndReport => {}
test::TestEvent::Sigint => {}
}
@@ -742,6 +745,10 @@ impl LspTestReporter {
}
}
+ fn report_completed(&mut self) {
+ // there is nothing to do on report_completed
+ }
+
fn report_summary(
&mut self,
_summary: &test::TestSummary,