diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2024-06-11 08:55:12 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-11 08:55:12 -0400 |
| commit | 4bc96c5d2ab46ff3ca1af1524c1913c2a5f2745c (patch) | |
| tree | 8452947b0267e47c795cadb02d2d1b44b3e40f81 /cli/lsp/resolver.rs | |
| parent | 6a356aff1380e79d67738c5b43aa2b5fee76600d (diff) | |
fix(npm): resolve dynamic npm imports individually (#24170)
* https://github.com/denoland/deno_npm/pull/57
* https://github.com/denoland/deno_graph/pull/498
Closes https://github.com/denoland/deno/issues/17802
Diffstat (limited to 'cli/lsp/resolver.rs')
| -rw-r--r-- | cli/lsp/resolver.rs | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/cli/lsp/resolver.rs b/cli/lsp/resolver.rs index d0a515063..bd09f0ad1 100644 --- a/cli/lsp/resolver.rs +++ b/cli/lsp/resolver.rs @@ -12,7 +12,6 @@ use crate::npm::CliNpmResolver; use crate::npm::CliNpmResolverByonmCreateOptions; use crate::npm::CliNpmResolverCreateOptions; use crate::npm::CliNpmResolverManagedCreateOptions; -use crate::npm::CliNpmResolverManagedPackageJsonInstallerOption; use crate::npm::CliNpmResolverManagedSnapshotOption; use crate::npm::ManagedCliNpmResolver; use crate::resolver::CliGraphResolver; @@ -347,9 +346,11 @@ async fn create_npm_resolver( cache_setting: CacheSetting::Only, text_only_progress_bar: ProgressBar::new(ProgressBarStyle::TextOnly), maybe_node_modules_path: config_data.node_modules_dir.clone(), - // do not install while resolving in the lsp—leave that to the cache command - package_json_installer: - CliNpmResolverManagedPackageJsonInstallerOption::NoInstall, + package_json_deps_provider: Arc::new(PackageJsonDepsProvider::new( + config_data.package_json.as_ref().map(|package_json| { + package_json::get_local_package_json_version_reqs(package_json) + }), + )), npmrc: config_data .npmrc .clone() |