diff options
author | Andreu Botella <andreu@andreubotella.com> | 2022-03-29 14:44:33 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-03-29 14:44:33 +0200 |
commit | d983b577bc903f18028a99d0a40a17322ac80ffe (patch) | |
tree | 177395212614bc600cb8c073ecccec1469d9eec0 /cli/lsp/language_server.rs | |
parent | f7ce96ea6e7a720d578b6f7f719fba90c8afdded (diff) |
chore(wasm): Don't await on the argument to `handleWasmStreaming` (#14000)
`handleWasmStreaming` is the function that provides the binding with
the `fetch` API needed for `WebAssembly.instantiateStreaming()` and
`WebAssembly.compileStreaming()`. When I implemented it in #11200, I
thought V8 was calling these functions with the argument of the
`WebAssembly` streaming functions, without doing any resolving, and so
`handleWasmStreaming` awaits for the parameter to resolve. However,
as discovered in
https://github.com/denoland/deno/issues/13917#issuecomment-1065805565,
V8 does in fact resolve the parameter if it's a promise (and handles
rejections arising from that).
This change removes the `async` IIFE inside `handleWasmStreaming`,
letting initial errors be handled synchronously (which will however
not throw synchronously from the `WebAssembly` namespace functions).
Awaiting is still necessary for reading the bytes of the response,
though, and so there is an `async` IIFE for that.
Diffstat (limited to 'cli/lsp/language_server.rs')
0 files changed, 0 insertions, 0 deletions