summaryrefslogtreecommitdiff
path: root/cli/lsp/diagnostics.rs
diff options
context:
space:
mode:
authorKitson Kelly <me@kitsonkelly.com>2020-12-30 12:46:58 +1100
committerGitHub <noreply@github.com>2020-12-30 12:46:58 +1100
commite8a81724bb3b3767edaddbe78edc52108ae78b5f (patch)
treeacbb7dc356519a77f810db2c203a6fafabf7cdf0 /cli/lsp/diagnostics.rs
parent268e47c0d8a9fa7b7c16f6862f22361add370796 (diff)
fix(lsp): handle ts debug errors better (#8914)
Fixes #8864
Diffstat (limited to 'cli/lsp/diagnostics.rs')
-rw-r--r--cli/lsp/diagnostics.rs14
1 files changed, 2 insertions, 12 deletions
diff --git a/cli/lsp/diagnostics.rs b/cli/lsp/diagnostics.rs
index c468fb0fa..ac938d063 100644
--- a/cli/lsp/diagnostics.rs
+++ b/cli/lsp/diagnostics.rs
@@ -244,20 +244,10 @@ pub async fn generate_ts_diagnostics(
let version = doc_data.version;
let current_version = diagnostic_collection.get_version(&file_id);
if version != current_version {
- // TODO(@kitsonk): consider refactoring to get all diagnostics in one shot
- // for a file.
- let req = tsc::RequestMethod::GetSemanticDiagnostics(specifier.clone());
- let mut ts_diagnostics = ts_json_to_diagnostics(
+ let req = tsc::RequestMethod::GetDiagnostics(specifier.clone());
+ let ts_diagnostics = ts_json_to_diagnostics(
ts_server.request(state_snapshot.clone(), req).await?,
)?;
- let req = tsc::RequestMethod::GetSuggestionDiagnostics(specifier.clone());
- ts_diagnostics.append(&mut ts_json_to_diagnostics(
- ts_server.request(state_snapshot.clone(), req).await?,
- )?);
- let req = tsc::RequestMethod::GetSyntacticDiagnostics(specifier.clone());
- ts_diagnostics.append(&mut ts_json_to_diagnostics(
- ts_server.request(state_snapshot.clone(), req).await?,
- )?);
diagnostics.push((file_id, version, ts_diagnostics));
}
}