diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2023-03-12 23:32:59 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-12 23:32:59 -0400 |
| commit | bcb6ee9d0864f490f6da47cbe2593310b21333ff (patch) | |
| tree | e2e06d2466dec8022645e368455c1ed8f59cab7f /cli/lsp/diagnostics.rs | |
| parent | 8db853514caae431a0ce91360d854c1b7f3c405f (diff) | |
refactor(npm): push npm struct creation to a higher level (#18139)
This has been bothering me for a while and it became more painful while
working on #18136 because injecting the shared progress bar became very
verbose. Basically we should move the creation of all these npm structs
up to a higher level.
This is a stepping stone for a future refactor where we can improve how
we create all our structs.
Diffstat (limited to 'cli/lsp/diagnostics.rs')
| -rw-r--r-- | cli/lsp/diagnostics.rs | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/cli/lsp/diagnostics.rs b/cli/lsp/diagnostics.rs index 380323dba..8c1c91da0 100644 --- a/cli/lsp/diagnostics.rs +++ b/cli/lsp/diagnostics.rs @@ -911,7 +911,6 @@ fn diagnose_resolution( if let Some(npm_resolver) = &snapshot.maybe_npm_resolver { // show diagnostics for npm package references that aren't cached if npm_resolver - .resolution() .resolve_pkg_id_from_pkg_req(&pkg_ref.req) .is_err() { @@ -933,7 +932,6 @@ fn diagnose_resolution( let types_node_ref = NpmPackageReqReference::from_str("npm:@types/node").unwrap(); if npm_resolver - .resolution() .resolve_pkg_id_from_pkg_req(&types_node_ref.req) .is_err() { |