summaryrefslogtreecommitdiff
path: root/cli/lsp/completions.rs
diff options
context:
space:
mode:
authorNayeem Rahman <nayeemrmn99@gmail.com>2023-09-19 13:01:06 +0100
committerGitHub <noreply@github.com>2023-09-19 12:01:06 +0000
commit9004117790fa23904daffafd347613820bda84ab (patch)
treed8cb519b4500766fc946a21d6e30491065e26125 /cli/lsp/completions.rs
parent2772d302f57cfdce09c7ba2df8a887d28eba8b9a (diff)
fix(lsp): refresh npm completions on each character (#20565)
Diffstat (limited to 'cli/lsp/completions.rs')
-rw-r--r--cli/lsp/completions.rs7
1 files changed, 4 insertions, 3 deletions
diff --git a/cli/lsp/completions.rs b/cli/lsp/completions.rs
index 7f11daef2..94111fee8 100644
--- a/cli/lsp/completions.rs
+++ b/cli/lsp/completions.rs
@@ -167,10 +167,11 @@ pub async fn get_import_completions(
items: get_local_completions(specifier, &text, &range)?,
}))
} else if text.starts_with("npm:") {
+ let items =
+ get_npm_completions(specifier, &text, &range, npm_search_api).await?;
Some(lsp::CompletionResponse::List(lsp::CompletionList {
- is_incomplete: false,
- items: get_npm_completions(specifier, &text, &range, npm_search_api)
- .await?,
+ is_incomplete: !items.is_empty(),
+ items,
}))
} else if !text.is_empty() {
// completion of modules from a module registry or cache