diff options
| author | David Sherret <dsherret@users.noreply.github.com> | 2023-03-15 10:34:23 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-15 14:34:23 +0000 |
| commit | 7070b8ed50f13d95d926b19ed7d7ce9fc0d6d4f3 (patch) | |
| tree | 1cba1972e1b7fcea1706a893984a3be12093cf1c /cli/lsp/completions.rs | |
| parent | 2ca160702795bb1b92196a848f7e4814d23ed32c (diff) | |
fix(lsp): avoid calling client while holding lock (#18197)
Diffstat (limited to 'cli/lsp/completions.rs')
| -rw-r--r-- | cli/lsp/completions.rs | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/cli/lsp/completions.rs b/cli/lsp/completions.rs index 3651fbeec..a767c4d82 100644 --- a/cli/lsp/completions.rs +++ b/cli/lsp/completions.rs @@ -48,7 +48,7 @@ pub struct CompletionItemData { async fn check_auto_config_registry( url_str: &str, config: &ConfigSnapshot, - client: Client, + client: &Client, module_registries: &ModuleRegistry, ) { // check to see if auto discovery is enabled @@ -78,14 +78,12 @@ async fn check_auto_config_registry( // incompatible. // TODO(@kitsonk) clean up protocol when doing v2 of suggestions if suggestions { - client - .send_registry_state_notification( - lsp_custom::RegistryStateNotificationParams { - origin, - suggestions, - }, - ) - .await; + client.send_registry_state_notification( + lsp_custom::RegistryStateNotificationParams { + origin, + suggestions, + }, + ); } } } @@ -139,7 +137,7 @@ pub async fn get_import_completions( specifier: &ModuleSpecifier, position: &lsp::Position, config: &ConfigSnapshot, - client: Client, + client: &Client, module_registries: &ModuleRegistry, documents: &Documents, maybe_import_map: Option<Arc<ImportMap>>, |